Title: [134009] trunk/Source/WebKit/chromium
- Revision
- 134009
- Author
- kei...@webkit.org
- Date
- 2012-11-08 22:24:13 -0800 (Thu, 08 Nov 2012)
Log Message
WebPagePopupImpl::handleKeyEvent is called after WebPagePopupImpl::close
https://bugs.webkit.org/show_bug.cgi?id=93800
Reviewed by Kent Tamura.
We need to set m_closing to true in WebPagePopupImpl::close so we won't access m_page in WebPagePopupImpl::handleKeyEvent.
* src/WebPagePopupImpl.cpp:
(WebKit::WebPagePopupImpl::close): Set m_closing to true.
Modified Paths
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (134008 => 134009)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-11-09 06:17:31 UTC (rev 134008)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-11-09 06:24:13 UTC (rev 134009)
@@ -1,3 +1,15 @@
+2012-11-08 Keishi Hattori <kei...@webkit.org>
+
+ WebPagePopupImpl::handleKeyEvent is called after WebPagePopupImpl::close
+ https://bugs.webkit.org/show_bug.cgi?id=93800
+
+ Reviewed by Kent Tamura.
+
+ We need to set m_closing to true in WebPagePopupImpl::close so we won't access m_page in WebPagePopupImpl::handleKeyEvent.
+
+ * src/WebPagePopupImpl.cpp:
+ (WebKit::WebPagePopupImpl::close): Set m_closing to true.
+
2012-11-08 Sheriff Bot <webkit.review....@gmail.com>
Unreviewed, rolling out r133984.
Modified: trunk/Source/WebKit/chromium/src/WebPagePopupImpl.cpp (134008 => 134009)
--- trunk/Source/WebKit/chromium/src/WebPagePopupImpl.cpp 2012-11-09 06:17:31 UTC (rev 134008)
+++ trunk/Source/WebKit/chromium/src/WebPagePopupImpl.cpp 2012-11-09 06:24:13 UTC (rev 134009)
@@ -304,6 +304,7 @@
void WebPagePopupImpl::close()
{
+ m_closing = true;
if (m_page && m_page->mainFrame())
m_page->mainFrame()->loader()->frameDetached();
m_page.clear();
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
