Title: [134068] trunk/Tools
- Revision
- 134068
- Author
- [email protected]
- Date
- 2012-11-09 07:49:46 -0800 (Fri, 09 Nov 2012)
Log Message
[WTR][Cairo] Do not call paintRepaintRectOverlay() when there is no repaint rect.
https://bugs.webkit.org/show_bug.cgi?id=101759
Reviewed by Kenneth Rohde Christiansen.
* WebKitTestRunner/cairo/TestInvocationCairo.cpp:
(WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Improve
the check for an empty repaintRect -- we need to check if the
WKArrayRef has any items. `if (repaintRect)' will return true
regardless of whether the array is empty or not.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (134067 => 134068)
--- trunk/Tools/ChangeLog 2012-11-09 15:32:17 UTC (rev 134067)
+++ trunk/Tools/ChangeLog 2012-11-09 15:49:46 UTC (rev 134068)
@@ -1,3 +1,17 @@
+2012-11-09 Raphael Kubo da Costa <[email protected]>
+
+ [WTR][Cairo] Do not call paintRepaintRectOverlay() when there is no repaint rect.
+ https://bugs.webkit.org/show_bug.cgi?id=101759
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
+ (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Improve
+ the check for an empty repaintRect -- we need to check if the
+ WKArrayRef has any items. `if (repaintRect)' will return true
+ regardless of whether the array is empty or not.
+
+
2012-11-09 Tor Arne Vestbø <[email protected]>
[Qt] Stop watchlist from triggering QtBuildSystem rule on DerivedSources
Modified: trunk/Tools/WebKitTestRunner/cairo/TestInvocationCairo.cpp (134067 => 134068)
--- trunk/Tools/WebKitTestRunner/cairo/TestInvocationCairo.cpp 2012-11-09 15:32:17 UTC (rev 134067)
+++ trunk/Tools/WebKitTestRunner/cairo/TestInvocationCairo.cpp 2012-11-09 15:49:46 UTC (rev 134068)
@@ -108,7 +108,7 @@
{
cairo_surface_t* surface = WKImageCreateCairoSurface(wkImage);
- if (repaintRects)
+ if (WKArrayGetSize(repaintRects))
paintRepaintRectOverlay(surface, repaintRects);
char actualHash[33];
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
