Title: [134086] trunk/Source/WebCore
- Revision
- 134086
- Author
- [email protected]
- Date
- 2012-11-09 10:55:17 -0800 (Fri, 09 Nov 2012)
Log Message
[V8] Remove a level of indirection in DOMDataStore
https://bugs.webkit.org/show_bug.cgi?id=101690
Reviewed by Kentaro Hara.
There is no longer any reason for the DOMDataStore to hold the wrapper
map via a pointer. It can just hold the wrapper map directly, saving a
level of indirection. I doubt this has any measurable performance gain.
* bindings/v8/DOMDataStore.cpp:
(WebCore::DOMDataStore::DOMDataStore):
(WebCore::DOMDataStore::~DOMDataStore):
(WebCore::DOMDataStore::reportMemoryUsage):
* bindings/v8/DOMDataStore.h:
(WebCore::DOMDataStore::get):
(WebCore::DOMDataStore::set):
(DOMDataStore):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (134085 => 134086)
--- trunk/Source/WebCore/ChangeLog 2012-11-09 18:24:37 UTC (rev 134085)
+++ trunk/Source/WebCore/ChangeLog 2012-11-09 18:55:17 UTC (rev 134086)
@@ -1,3 +1,23 @@
+2012-11-09 Adam Barth <[email protected]>
+
+ [V8] Remove a level of indirection in DOMDataStore
+ https://bugs.webkit.org/show_bug.cgi?id=101690
+
+ Reviewed by Kentaro Hara.
+
+ There is no longer any reason for the DOMDataStore to hold the wrapper
+ map via a pointer. It can just hold the wrapper map directly, saving a
+ level of indirection. I doubt this has any measurable performance gain.
+
+ * bindings/v8/DOMDataStore.cpp:
+ (WebCore::DOMDataStore::DOMDataStore):
+ (WebCore::DOMDataStore::~DOMDataStore):
+ (WebCore::DOMDataStore::reportMemoryUsage):
+ * bindings/v8/DOMDataStore.h:
+ (WebCore::DOMDataStore::get):
+ (WebCore::DOMDataStore::set):
+ (DOMDataStore):
+
2012-11-09 Mihnea Ovidenie <[email protected]>
[CSSRegions] Region styling properties are not filtered correctly
Modified: trunk/Source/WebCore/bindings/v8/DOMDataStore.cpp (134085 => 134086)
--- trunk/Source/WebCore/bindings/v8/DOMDataStore.cpp 2012-11-09 18:24:37 UTC (rev 134085)
+++ trunk/Source/WebCore/bindings/v8/DOMDataStore.cpp 2012-11-09 18:55:17 UTC (rev 134086)
@@ -41,7 +41,6 @@
DOMDataStore::DOMDataStore(Type type)
: m_type(type)
{
- m_domObjectMap = adoptPtr(new DOMWrapperMap<void>);
V8PerIsolateData::current()->registerDOMDataStore(this);
}
@@ -49,7 +48,7 @@
{
ASSERT(m_type != MainWorld); // We never actually destruct the main world's DOMDataStore.
V8PerIsolateData::current()->unregisterDOMDataStore(this);
- m_domObjectMap->clear();
+ m_wrapperMap.clear();
}
DOMDataStore* DOMDataStore::current(v8::Isolate* isolate)
@@ -67,7 +66,7 @@
void DOMDataStore::reportMemoryUsage(MemoryObjectInfo* memoryObjectInfo) const
{
MemoryClassInfo info(memoryObjectInfo, this, WebCoreMemoryTypes::Binding);
- info.addMember(m_domObjectMap);
+ info.addMember(m_wrapperMap);
}
void DOMDataStore::weakCallback(v8::Persistent<v8::Value> value, void* context)
Modified: trunk/Source/WebCore/bindings/v8/DOMDataStore.h (134085 => 134086)
--- trunk/Source/WebCore/bindings/v8/DOMDataStore.h 2012-11-09 18:24:37 UTC (rev 134085)
+++ trunk/Source/WebCore/bindings/v8/DOMDataStore.h 2012-11-09 18:55:17 UTC (rev 134086)
@@ -60,11 +60,11 @@
static DOMDataStore* current(v8::Isolate*);
template<typename T>
- inline v8::Handle<v8::Object> get(T* object) const
+ inline v8::Handle<v8::Object> get(T* object)
{
if (wrapperIsStoredInObject(object))
return getWrapperFromObject(object);
- return m_domObjectMap->get(object);
+ return m_wrapperMap.get(object);
}
template<typename T>
@@ -72,7 +72,7 @@
{
if (setWrapperInObject(object, wrapper))
return;
- m_domObjectMap->set(object, wrapper);
+ m_wrapperMap.set(object, wrapper);
}
void reportMemoryUsage(MemoryObjectInfo*) const;
@@ -107,7 +107,7 @@
static void weakCallback(v8::Persistent<v8::Value>, void* context);
Type m_type;
- OwnPtr<DOMWrapperMap<void> > m_domObjectMap;
+ DOMWrapperMap<void> m_wrapperMap;
};
} // namespace WebCore
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
