Title: [134093] trunk/Source/WebCore
- Revision
- 134093
- Author
- [email protected]
- Date
- 2012-11-09 11:39:01 -0800 (Fri, 09 Nov 2012)
Log Message
MediaStream API: Don't trigger any object deletion during RTCPeerConnection::stop
https://bugs.webkit.org/show_bug.cgi?id=101586
Reviewed by Adam Barth.
Stop calling stop on the RTCPeerConnectionHandler, and don't delete it, when
ActiveDOMObject::stop is called on RTCPeerConnection. Due to the async nature of the new
API some WebCore objects might be cleaned away which is not allowed at this stage.
This behaviour is not possible to test unfortunately in webkit.
* Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::stop):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (134092 => 134093)
--- trunk/Source/WebCore/ChangeLog 2012-11-09 19:32:19 UTC (rev 134092)
+++ trunk/Source/WebCore/ChangeLog 2012-11-09 19:39:01 UTC (rev 134093)
@@ -1,3 +1,19 @@
+2012-11-09 Tommy Widenflycht <[email protected]>
+
+ MediaStream API: Don't trigger any object deletion during RTCPeerConnection::stop
+ https://bugs.webkit.org/show_bug.cgi?id=101586
+
+ Reviewed by Adam Barth.
+
+ Stop calling stop on the RTCPeerConnectionHandler, and don't delete it, when
+ ActiveDOMObject::stop is called on RTCPeerConnection. Due to the async nature of the new
+ API some WebCore objects might be cleaned away which is not allowed at this stage.
+
+ This behaviour is not possible to test unfortunately in webkit.
+
+ * Modules/mediastream/RTCPeerConnection.cpp:
+ (WebCore::RTCPeerConnection::stop):
+
2012-11-09 Joshua Bell <[email protected]>
[Chromium] Unreviewed gardening. Fix chromium-win builds following r134082
Modified: trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp (134092 => 134093)
--- trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp 2012-11-09 19:32:19 UTC (rev 134092)
+++ trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp 2012-11-09 19:39:01 UTC (rev 134093)
@@ -523,11 +523,6 @@
void RTCPeerConnection::stop()
{
- if (m_readyState != ReadyStateClosed)
- m_peerHandler->stop();
-
- m_peerHandler.clear();
-
m_iceState = IceStateClosed;
m_readyState = ReadyStateClosed;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
