Title: [134119] trunk/Source
- Revision
- 134119
- Author
- [email protected]
- Date
- 2012-11-09 15:25:19 -0800 (Fri, 09 Nov 2012)
Log Message
Implement WebResourceBuffer::isEmpty()
https://bugs.webkit.org/show_bug.cgi?id=101805
Reviewed by Alexey Proskuryakov.
This is required to make the existing subresource loading in NetworkProcess work correctly,
as there's an isEmpty() check in the WebProcess that decides whether or not to actually deliver
the data to the ResourceLoader.
Source/WebCore:
No new tests (No change in behavior in any configuration we test.)
* loader/ResourceBuffer.h: Make isEmpty() virtual.
Source/WebKit2:
* Shared/WebResourceBuffer.cpp:
(WebKit::WebResourceBuffer::isEmpty):
* Shared/WebResourceBuffer.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (134118 => 134119)
--- trunk/Source/WebCore/ChangeLog 2012-11-09 22:36:08 UTC (rev 134118)
+++ trunk/Source/WebCore/ChangeLog 2012-11-09 23:25:19 UTC (rev 134119)
@@ -1,3 +1,18 @@
+2012-11-09 Brady Eidson <[email protected]>
+
+ Implement WebResourceBuffer::isEmpty()
+ https://bugs.webkit.org/show_bug.cgi?id=101805
+
+ Reviewed by Alexey Proskuryakov.
+
+ This is required to make the existing subresource loading in NetworkProcess work correctly,
+ as there's an isEmpty() check in the WebProcess that decides whether or not to actually deliver
+ the data to the ResourceLoader.
+
+ No new tests (No change in behavior in any configuration we test.)
+
+ * loader/ResourceBuffer.h: Make isEmpty() virtual.
+
2012-11-09 Michael Saboff <[email protected]>
HTML Attributes names and values should be created as 8 bit string where possible
Modified: trunk/Source/WebCore/loader/ResourceBuffer.h (134118 => 134119)
--- trunk/Source/WebCore/loader/ResourceBuffer.h 2012-11-09 22:36:08 UTC (rev 134118)
+++ trunk/Source/WebCore/loader/ResourceBuffer.h 2012-11-09 23:25:19 UTC (rev 134119)
@@ -52,7 +52,7 @@
virtual const char* data() const;
virtual unsigned size() const;
- bool isEmpty() const;
+ virtual bool isEmpty() const;
void append(const char*, unsigned);
void clear();
Modified: trunk/Source/WebKit2/ChangeLog (134118 => 134119)
--- trunk/Source/WebKit2/ChangeLog 2012-11-09 22:36:08 UTC (rev 134118)
+++ trunk/Source/WebKit2/ChangeLog 2012-11-09 23:25:19 UTC (rev 134119)
@@ -1,3 +1,18 @@
+2012-11-09 Brady Eidson <[email protected]>
+
+ Implement WebResourceBuffer::isEmpty()
+ https://bugs.webkit.org/show_bug.cgi?id=101805
+
+ Reviewed by Alexey Proskuryakov.
+
+ This is required to make the existing subresource loading in NetworkProcess work correctly,
+ as there's an isEmpty() check in the WebProcess that decides whether or not to actually deliver
+ the data to the ResourceLoader.
+
+ * Shared/WebResourceBuffer.cpp:
+ (WebKit::WebResourceBuffer::isEmpty):
+ * Shared/WebResourceBuffer.h:
+
2012-11-09 Hurnjoo Lee <[email protected]>
[EFL][WK2][AC] Fixed layers are shaking when scrolling
Modified: trunk/Source/WebKit2/Shared/WebResourceBuffer.cpp (134118 => 134119)
--- trunk/Source/WebKit2/Shared/WebResourceBuffer.cpp 2012-11-09 22:36:08 UTC (rev 134118)
+++ trunk/Source/WebKit2/Shared/WebResourceBuffer.cpp 2012-11-09 23:25:19 UTC (rev 134119)
@@ -51,4 +51,9 @@
return m_resource->size();
}
+bool WebResourceBuffer::isEmpty() const
+{
+ return !m_resource || !m_resource->size();
+}
+
} // namespace WebKit
Modified: trunk/Source/WebKit2/Shared/WebResourceBuffer.h (134118 => 134119)
--- trunk/Source/WebKit2/Shared/WebResourceBuffer.h 2012-11-09 22:36:08 UTC (rev 134118)
+++ trunk/Source/WebKit2/Shared/WebResourceBuffer.h 2012-11-09 23:25:19 UTC (rev 134119)
@@ -40,6 +40,7 @@
virtual const char* data() const OVERRIDE;
virtual unsigned size() const OVERRIDE;
+ virtual bool isEmpty() const OVERRIDE;
private:
WebResourceBuffer(PassRefPtr<ShareableResource>);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
