Title: [134159] trunk/Source/WebCore
- Revision
- 134159
- Author
- [email protected]
- Date
- 2012-11-10 10:25:10 -0800 (Sat, 10 Nov 2012)
Log Message
[V8] Clean up header includes and ifdefs in V8GCController
https://bugs.webkit.org/show_bug.cgi?id=101691
Reviewed by Kentaro Hara.
This file doesn't need to include all these headers anymore.
* bindings/v8/V8GCController.cpp:
(WebCore::workingSetEstimateMBMutex):
(WebCore::V8GCController::majorGCEpilogue):
(WebCore::V8GCController::checkMemoryUsage):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (134158 => 134159)
--- trunk/Source/WebCore/ChangeLog 2012-11-10 16:11:04 UTC (rev 134158)
+++ trunk/Source/WebCore/ChangeLog 2012-11-10 18:25:10 UTC (rev 134159)
@@ -1,3 +1,17 @@
+2012-11-10 Adam Barth <[email protected]>
+
+ [V8] Clean up header includes and ifdefs in V8GCController
+ https://bugs.webkit.org/show_bug.cgi?id=101691
+
+ Reviewed by Kentaro Hara.
+
+ This file doesn't need to include all these headers anymore.
+
+ * bindings/v8/V8GCController.cpp:
+ (WebCore::workingSetEstimateMBMutex):
+ (WebCore::V8GCController::majorGCEpilogue):
+ (WebCore::V8GCController::checkMemoryUsage):
+
2012-11-10 Joseph Pecoraro <[email protected]>
[Mac] Guard WebCore PageVisibility Symbol Export
Modified: trunk/Source/WebCore/bindings/v8/V8GCController.cpp (134158 => 134159)
--- trunk/Source/WebCore/bindings/v8/V8GCController.cpp 2012-11-10 16:11:04 UTC (rev 134158)
+++ trunk/Source/WebCore/bindings/v8/V8GCController.cpp 2012-11-10 18:25:10 UTC (rev 134159)
@@ -31,40 +31,18 @@
#include "config.h"
#include "V8GCController.h"
-#include "ActiveDOMObject.h"
#include "Attr.h"
-#include "DOMDataStore.h"
-#include "DOMImplementation.h"
#include "HTMLImageElement.h"
-#include "HTMLNames.h"
#include "MemoryUsageSupport.h"
-#include "MessagePort.h"
-#include "RetainedDOMInfo.h"
-#include "RetainedObjectInfo.h"
+#include "TraceEvent.h"
#include "V8AbstractEventListener.h"
#include "V8Binding.h"
-#include "V8CSSRule.h"
-#include "V8CSSRuleList.h"
-#include "V8CSSStyleDeclaration.h"
-#include "V8DOMImplementation.h"
#include "V8MessagePort.h"
#include "V8Node.h"
#include "V8RecursionScope.h"
-#include "V8StyleSheet.h"
-#include "V8StyleSheetList.h"
#include "WrapperTypeInfo.h"
-
#include <algorithm>
-#include <utility>
-#include <v8-debug.h>
-#include <wtf/HashMap.h>
-#include <wtf/StdLibExtras.h>
-#include <wtf/UnusedParam.h>
-#if PLATFORM(CHROMIUM)
-#include "TraceEvent.h"
-#endif
-
namespace WebCore {
class ImplicitConnection {
@@ -256,7 +234,6 @@
data->stringCache()->clearOnGC();
}
-#if PLATFORM(CHROMIUM)
static int workingSetEstimateMB = 0;
static Mutex& workingSetEstimateMBMutex()
@@ -264,7 +241,6 @@
AtomicallyInitializedStatic(Mutex&, mutex = *new Mutex);
return mutex;
}
-#endif
void V8GCController::gcEpilogue(v8::GCType type, v8::GCCallbackFlags flags)
{
@@ -282,20 +258,17 @@
{
v8::HandleScope scope;
-#if PLATFORM(CHROMIUM)
// The GC can happen on multiple threads in case of dedicated workers which run in-process.
{
MutexLocker locker(workingSetEstimateMBMutex());
workingSetEstimateMB = MemoryUsageSupport::actualMemoryUsageMB();
}
-#endif
TRACE_EVENT_END0("v8", "GC");
}
void V8GCController::checkMemoryUsage()
{
-#if PLATFORM(CHROMIUM)
const int lowMemoryUsageMB = MemoryUsageSupport::lowMemoryUsageMB();
const int highMemoryUsageMB = MemoryUsageSupport::highMemoryUsageMB();
const int highUsageDeltaMB = MemoryUsageSupport::highUsageDeltaMB();
@@ -319,7 +292,6 @@
// We are approaching OOM and memory usage increased by highUsageDeltaMB since the last GC.
v8::V8::LowMemoryNotification();
}
-#endif
}
void V8GCController::hintForCollectGarbage()
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
