Title: [134167] trunk/Source/WebCore
- Revision
- 134167
- Author
- [email protected]
- Date
- 2012-11-10 16:55:37 -0800 (Sat, 10 Nov 2012)
Log Message
Unreviewed, rolling out r134069.
http://trac.webkit.org/changeset/134069
https://bugs.webkit.org/show_bug.cgi?id=101852
"It is a wrong way to fix the problem. See discussions in bug
96614" (Requested by 1JTAAPQFJ on #webkit).
Patch by Sheriff Bot <[email protected]> on 2012-11-10
* bindings/js/JSDictionary.cpp:
(WebCore::JSDictionary::getWithUndefinedOrNullCheck):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (134166 => 134167)
--- trunk/Source/WebCore/ChangeLog 2012-11-11 00:20:30 UTC (rev 134166)
+++ trunk/Source/WebCore/ChangeLog 2012-11-11 00:55:37 UTC (rev 134167)
@@ -1,3 +1,15 @@
+2012-11-10 Sheriff Bot <[email protected]>
+
+ Unreviewed, rolling out r134069.
+ http://trac.webkit.org/changeset/134069
+ https://bugs.webkit.org/show_bug.cgi?id=101852
+
+ "It is a wrong way to fix the problem. See discussions in bug
+ 96614" (Requested by 1JTAAPQFJ on #webkit).
+
+ * bindings/js/JSDictionary.cpp:
+ (WebCore::JSDictionary::getWithUndefinedOrNullCheck):
+
2012-11-10 Mike West <[email protected]>
Web Inspector: Multiple '%c' formatting options should all have effect.
Modified: trunk/Source/WebCore/bindings/js/JSDictionary.cpp (134166 => 134167)
--- trunk/Source/WebCore/bindings/js/JSDictionary.cpp 2012-11-11 00:20:30 UTC (rev 134166)
+++ trunk/Source/WebCore/bindings/js/JSDictionary.cpp 2012-11-11 00:55:37 UTC (rev 134167)
@@ -216,11 +216,6 @@
{
ASSERT(isValid());
JSValue value;
-
- // FIXME: This check should be moved to the head of JSDictionary::tryGetProperty(propertyName, JSValue&)
- // Currently we can't move the check there because it seems breaks some Qt/EFL tests for some reason.
- if (m_exec->hadException()) // Clear exceptions that might have been caused by previous query.
- m_exec->clearException();
if (tryGetProperty(propertyName.utf8().data(), value) != PropertyFound || value.isUndefinedOrNull())
return false;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
