Title: [134186] trunk/Source/WebCore
- Revision
- 134186
- Author
- [email protected]
- Date
- 2012-11-11 20:42:06 -0800 (Sun, 11 Nov 2012)
Log Message
[V8] HTMLDocument::all() needs not to be custom
https://bugs.webkit.org/show_bug.cgi?id=101875
Reviewed by Adam Barth.
We can easily remove the custom getter from V8 because the
custom setter sets .all by ForceSet(). On the other hand,
it is non-trivial to remove the custom getter from JSC
because the custom setter sets .all by putDirect()
and the custom getter wants to get it by getDirect().
No tests. No change in behavior.
* bindings/v8/custom/V8HTMLDocumentCustom.cpp:
* html/HTMLDocument.idl:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (134185 => 134186)
--- trunk/Source/WebCore/ChangeLog 2012-11-12 04:29:32 UTC (rev 134185)
+++ trunk/Source/WebCore/ChangeLog 2012-11-12 04:42:06 UTC (rev 134186)
@@ -1,5 +1,23 @@
2012-11-11 Kentaro Hara <[email protected]>
+ [V8] HTMLDocument::all() needs not to be custom
+ https://bugs.webkit.org/show_bug.cgi?id=101875
+
+ Reviewed by Adam Barth.
+
+ We can easily remove the custom getter from V8 because the
+ custom setter sets .all by ForceSet(). On the other hand,
+ it is non-trivial to remove the custom getter from JSC
+ because the custom setter sets .all by putDirect()
+ and the custom getter wants to get it by getDirect().
+
+ No tests. No change in behavior.
+
+ * bindings/v8/custom/V8HTMLDocumentCustom.cpp:
+ * html/HTMLDocument.idl:
+
+2012-11-11 Kentaro Hara <[email protected]>
+
[V8] V8Console::memoryAttrGetter() needs not to be custom
https://bugs.webkit.org/show_bug.cgi?id=101873
Modified: trunk/Source/WebCore/bindings/v8/custom/V8HTMLDocumentCustom.cpp (134185 => 134186)
--- trunk/Source/WebCore/bindings/v8/custom/V8HTMLDocumentCustom.cpp 2012-11-12 04:29:32 UTC (rev 134185)
+++ trunk/Source/WebCore/bindings/v8/custom/V8HTMLDocumentCustom.cpp 2012-11-12 04:42:06 UTC (rev 134186)
@@ -162,14 +162,6 @@
return args.Holder();
}
-v8::Handle<v8::Value> V8HTMLDocument::allAccessorGetter(v8::Local<v8::String> name, const v8::AccessorInfo& info)
-{
- INC_STATS("DOM.HTMLDocument.all._get");
- v8::Handle<v8::Object> holder = info.Holder();
- HTMLDocument* htmlDocument = V8HTMLDocument::toNative(holder);
- return toV8(htmlDocument->all(), info.Holder(), info.GetIsolate());
-}
-
void V8HTMLDocument::allAccessorSetter(v8::Local<v8::String> name, v8::Local<v8::Value> value, const v8::AccessorInfo& info)
{
// Just emulate a normal JS behaviour---install a property on this.
Modified: trunk/Source/WebCore/html/HTMLDocument.idl (134185 => 134186)
--- trunk/Source/WebCore/html/HTMLDocument.idl 2012-11-12 04:29:32 UTC (rev 134185)
+++ trunk/Source/WebCore/html/HTMLDocument.idl 2012-11-12 04:42:06 UTC (rev 134186)
@@ -35,7 +35,7 @@
#if defined(LANGUAGE_JAVASCRIPT) && LANGUAGE_JAVASCRIPT
// FIXME: This should eventually be available (if they are wanted) for all languages.
- [Custom, Deletable] attribute HTMLAllCollection all;
+ [JSCustomGetter, CustomSetter, Deletable] attribute HTMLAllCollection all;
#endif
void clear();
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
