Title: [134189] trunk/Source/WebCore
- Revision
- 134189
- Author
- [email protected]
- Date
- 2012-11-11 22:35:20 -0800 (Sun, 11 Nov 2012)
Log Message
[Refactoring] Remove shadowPseudoId() and use setPseudo() in HTMLKeygenElement
https://bugs.webkit.org/show_bug.cgi?id=101881
Reviewed by Kent Tamura.
We're migrating shadowPseudoId() to pseudo(). We remove shadowPseudoId() from HTMLKeygenElement and use
setPseudo()/pseudo() instead.
No new tests, simple refacotring.
* html/HTMLKeygenElement.cpp:
(WebCore::KeygenSelectElement::KeygenSelectElement):
(KeygenSelectElement):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (134188 => 134189)
--- trunk/Source/WebCore/ChangeLog 2012-11-12 05:30:54 UTC (rev 134188)
+++ trunk/Source/WebCore/ChangeLog 2012-11-12 06:35:20 UTC (rev 134189)
@@ -1,3 +1,19 @@
+2012-11-11 Shinya Kawanaka <[email protected]>
+
+ [Refactoring] Remove shadowPseudoId() and use setPseudo() in HTMLKeygenElement
+ https://bugs.webkit.org/show_bug.cgi?id=101881
+
+ Reviewed by Kent Tamura.
+
+ We're migrating shadowPseudoId() to pseudo(). We remove shadowPseudoId() from HTMLKeygenElement and use
+ setPseudo()/pseudo() instead.
+
+ No new tests, simple refacotring.
+
+ * html/HTMLKeygenElement.cpp:
+ (WebCore::KeygenSelectElement::KeygenSelectElement):
+ (KeygenSelectElement):
+
2012-11-11 Adam Barth <[email protected]>
Many DOMWindowProperties would benefit from being ScriptWrappable
Modified: trunk/Source/WebCore/html/HTMLKeygenElement.cpp (134188 => 134189)
--- trunk/Source/WebCore/html/HTMLKeygenElement.cpp 2012-11-12 05:30:54 UTC (rev 134188)
+++ trunk/Source/WebCore/html/HTMLKeygenElement.cpp 2012-11-12 06:35:20 UTC (rev 134189)
@@ -50,16 +50,12 @@
return adoptRef(new KeygenSelectElement(document));
}
- virtual const AtomicString& shadowPseudoId() const
- {
- DEFINE_STATIC_LOCAL(AtomicString, pseudoId, ("-webkit-keygen-select", AtomicString::ConstructFromLiteral));
- return pseudoId;
- }
-
protected:
KeygenSelectElement(Document* document)
: HTMLSelectElement(selectTag, document, 0)
{
+ DEFINE_STATIC_LOCAL(AtomicString, pseudoId, ("-webkit-keygen-select", AtomicString::ConstructFromLiteral));
+ setPseudo(pseudoId);
}
private:
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes