Title: [134225] trunk/Source/WebCore
- Revision
- 134225
- Author
- [email protected]
- Date
- 2012-11-12 06:57:30 -0800 (Mon, 12 Nov 2012)
Log Message
[V8][JSC] HTMLElement::itemValue() needs not to be custom
https://bugs.webkit.org/show_bug.cgi?id=101882
Reviewed by Adam Barth.
We can remove a [Custom] IDL attribute.
No tests. No change in behavior.
* bindings/js/JSHTMLElementCustom.cpp:
* bindings/v8/custom/V8HTMLElementCustom.cpp:
* html/HTMLElement.idl:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (134224 => 134225)
--- trunk/Source/WebCore/ChangeLog 2012-11-12 14:42:24 UTC (rev 134224)
+++ trunk/Source/WebCore/ChangeLog 2012-11-12 14:57:30 UTC (rev 134225)
@@ -1,3 +1,18 @@
+2012-11-12 Kentaro Hara <[email protected]>
+
+ [V8][JSC] HTMLElement::itemValue() needs not to be custom
+ https://bugs.webkit.org/show_bug.cgi?id=101882
+
+ Reviewed by Adam Barth.
+
+ We can remove a [Custom] IDL attribute.
+
+ No tests. No change in behavior.
+
+ * bindings/js/JSHTMLElementCustom.cpp:
+ * bindings/v8/custom/V8HTMLElementCustom.cpp:
+ * html/HTMLElement.idl:
+
2012-11-12 Andreas Kling <[email protected]>
RenderStyle: Pack Color members tighter in substructures.
Modified: trunk/Source/WebCore/bindings/js/JSHTMLElementCustom.cpp (134224 => 134225)
--- trunk/Source/WebCore/bindings/js/JSHTMLElementCustom.cpp 2012-11-12 14:42:24 UTC (rev 134224)
+++ trunk/Source/WebCore/bindings/js/JSHTMLElementCustom.cpp 2012-11-12 14:57:30 UTC (rev 134225)
@@ -53,20 +53,4 @@
return JSWithScope::create(exec, asObject(toJS(exec, globalObject(), element)), scope);
}
-#if ENABLE(MICRODATA)
-JSValue JSHTMLElement::itemValue(ExecState* exec) const
-{
- HTMLElement* element = impl();
- return toJS(exec, globalObject(), WTF::getPtr(element->itemValue()));
-}
-
-void JSHTMLElement::setItemValue(ExecState* exec, JSValue value)
-{
- HTMLElement* imp = impl();
- ExceptionCode ec = 0;
- imp->setItemValue(valueToStringWithNullCheck(exec, value), ec);
- setDOMException(exec, ec);
-}
-#endif
-
} // namespace WebCore
Modified: trunk/Source/WebCore/bindings/v8/custom/V8HTMLElementCustom.cpp (134224 => 134225)
--- trunk/Source/WebCore/bindings/v8/custom/V8HTMLElementCustom.cpp 2012-11-12 14:42:24 UTC (rev 134224)
+++ trunk/Source/WebCore/bindings/v8/custom/V8HTMLElementCustom.cpp 2012-11-12 14:57:30 UTC (rev 134225)
@@ -47,21 +47,4 @@
return createV8HTMLWrapper(impl, creationContext, isolate);
}
-#if ENABLE(MICRODATA)
-v8::Handle<v8::Value> V8HTMLElement::itemValueAccessorGetter(v8::Local<v8::String> name, const v8::AccessorInfo& info)
-{
- HTMLElement* impl = V8HTMLElement::toNative(info.Holder());
- return toV8(impl->itemValue().get(), info.Holder(), info.GetIsolate());
-}
-
-void V8HTMLElement::itemValueAccessorSetter(v8::Local<v8::String> name, v8::Local<v8::Value> value, const v8::AccessorInfo& info)
-{
- HTMLElement* impl = V8HTMLElement::toNative(info.Holder());
- ExceptionCode ec = 0;
- impl->setItemValue(toWebCoreString(value), ec);
- if (ec)
- setDOMException(ec, info.GetIsolate());
-}
-#endif
-
} // namespace WebCore
Modified: trunk/Source/WebCore/html/HTMLElement.idl (134224 => 134225)
--- trunk/Source/WebCore/html/HTMLElement.idl 2012-11-12 14:42:24 UTC (rev 134224)
+++ trunk/Source/WebCore/html/HTMLElement.idl 2012-11-12 14:57:30 UTC (rev 134225)
@@ -78,12 +78,10 @@
#endif
#endif
-#if !defined(LANGUAGE_CPP) || !LANGUAGE_CPP
-#if !defined(LANGUAGE_OBJECTIVE_C) || !LANGUAGE_OBJECTIVE_C
- [Conditional=MICRODATA, Custom] attribute DOMObject itemValue
- setter raises(DOMException);
+#if defined(LANGUAGE_JAVASCRIPT) || LANGUAGE_JAVASCRIPT
+ [Conditional=MICRODATA] attribute DOMObject itemValue
+ setter raises(DOMException);
#endif
-#endif
#if defined(LANGUAGE_OBJECTIVE_C) && LANGUAGE_OBJECTIVE_C
readonly attribute DOMString titleDisplayString;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
