Title: [134248] trunk/Source/WebCore
- Revision
- 134248
- Author
- [email protected]
- Date
- 2012-11-12 09:42:19 -0800 (Mon, 12 Nov 2012)
Log Message
[V8][JSC] HTMLOptionsCollection::length needs not to be [Custom]
https://bugs.webkit.org/show_bug.cgi?id=101888
Reviewed by Adam Barth.
We can remove [Custom] from getter. It is possible to remove [Custom]
from setter, but it changes the current behavior.
(I think the current implementation of the setter is wrong.
I'll fix it in another patch.)
No tests. No change in behavior.
* bindings/js/JSHTMLOptionsCollectionCustom.cpp:
* bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
* html/HTMLOptionsCollection.idl:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (134247 => 134248)
--- trunk/Source/WebCore/ChangeLog 2012-11-12 17:34:46 UTC (rev 134247)
+++ trunk/Source/WebCore/ChangeLog 2012-11-12 17:42:19 UTC (rev 134248)
@@ -1,3 +1,21 @@
+2012-11-12 Kentaro Hara <[email protected]>
+
+ [V8][JSC] HTMLOptionsCollection::length needs not to be [Custom]
+ https://bugs.webkit.org/show_bug.cgi?id=101888
+
+ Reviewed by Adam Barth.
+
+ We can remove [Custom] from getter. It is possible to remove [Custom]
+ from setter, but it changes the current behavior.
+ (I think the current implementation of the setter is wrong.
+ I'll fix it in another patch.)
+
+ No tests. No change in behavior.
+
+ * bindings/js/JSHTMLOptionsCollectionCustom.cpp:
+ * bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
+ * html/HTMLOptionsCollection.idl:
+
2012-11-12 Yael Aharon <[email protected]>
[EFL][WK2][AC] Black screen when applications use software backend.
Modified: trunk/Source/WebCore/bindings/js/JSHTMLOptionsCollectionCustom.cpp (134247 => 134248)
--- trunk/Source/WebCore/bindings/js/JSHTMLOptionsCollectionCustom.cpp 2012-11-12 17:34:46 UTC (rev 134247)
+++ trunk/Source/WebCore/bindings/js/JSHTMLOptionsCollectionCustom.cpp 2012-11-12 17:42:19 UTC (rev 134248)
@@ -35,12 +35,6 @@
namespace WebCore {
-JSValue JSHTMLOptionsCollection::length(ExecState*) const
-{
- HTMLOptionsCollection* imp = static_cast<HTMLOptionsCollection*>(impl());
- return jsNumber(imp->length());
-}
-
void JSHTMLOptionsCollection::setLength(ExecState* exec, JSValue value)
{
HTMLOptionsCollection* imp = static_cast<HTMLOptionsCollection*>(impl());
Modified: trunk/Source/WebCore/bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp (134247 => 134248)
--- trunk/Source/WebCore/bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp 2012-11-12 17:34:46 UTC (rev 134247)
+++ trunk/Source/WebCore/bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp 2012-11-12 17:42:19 UTC (rev 134248)
@@ -82,14 +82,6 @@
return v8::Undefined();
}
-v8::Handle<v8::Value> V8HTMLOptionsCollection::lengthAccessorGetter(v8::Local<v8::String> name, const v8::AccessorInfo& info)
-{
- INC_STATS("DOM.HTMLOptionsCollection.length._get");
- HTMLOptionsCollection* imp = V8HTMLOptionsCollection::toNative(info.Holder());
- int v = imp->length();
- return v8Integer(v, info.GetIsolate());
-}
-
void V8HTMLOptionsCollection::lengthAccessorSetter(v8::Local<v8::String> name, v8::Local<v8::Value> value, const v8::AccessorInfo& info)
{
INC_STATS("DOM.HTMLOptionsCollection.length._set");
Modified: trunk/Source/WebCore/html/HTMLOptionsCollection.idl (134247 => 134248)
--- trunk/Source/WebCore/html/HTMLOptionsCollection.idl 2012-11-12 17:34:46 UTC (rev 134247)
+++ trunk/Source/WebCore/html/HTMLOptionsCollection.idl 2012-11-12 17:42:19 UTC (rev 134248)
@@ -23,7 +23,7 @@
CustomIndexedSetter
] interface HTMLOptionsCollection : HTMLCollection {
attribute long selectedIndex;
- [Custom] attribute unsigned long length
+ [CustomSetter] attribute unsigned long length
setter raises (DOMException);
[Custom] void add(in [Optional=DefaultIsUndefined] HTMLOptionElement option,
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
