Title: [134283] trunk/Source/WebCore
- Revision
- 134283
- Author
- [email protected]
- Date
- 2012-11-12 12:37:52 -0800 (Mon, 12 Nov 2012)
Log Message
Fix memory leak in createSurfaceForBackingStore()
https://bugs.webkit.org/show_bug.cgi?id=101941
Patch by Christophe Dumez <[email protected]> on 2012-11-12
Reviewed by Kenneth Rohde Christiansen.
Fix memory leak in createSurfaceForBackingStore(),
the RefPtr<cairo_surface_t> should be released
when returned since we pass ownership to the
caller.
No new tests, no behavior change for layout tests.
* platform/graphics/efl/CairoUtilitiesEfl.cpp:
(WebCore::createSurfaceForBackingStore):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (134282 => 134283)
--- trunk/Source/WebCore/ChangeLog 2012-11-12 20:34:27 UTC (rev 134282)
+++ trunk/Source/WebCore/ChangeLog 2012-11-12 20:37:52 UTC (rev 134283)
@@ -1,3 +1,20 @@
+2012-11-12 Christophe Dumez <[email protected]>
+
+ Fix memory leak in createSurfaceForBackingStore()
+ https://bugs.webkit.org/show_bug.cgi?id=101941
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ Fix memory leak in createSurfaceForBackingStore(),
+ the RefPtr<cairo_surface_t> should be released
+ when returned since we pass ownership to the
+ caller.
+
+ No new tests, no behavior change for layout tests.
+
+ * platform/graphics/efl/CairoUtilitiesEfl.cpp:
+ (WebCore::createSurfaceForBackingStore):
+
2012-11-12 Joe Mason <[email protected]>
[BlackBerry] Update to new proxyInfo API
Modified: trunk/Source/WebCore/platform/graphics/efl/CairoUtilitiesEfl.cpp (134282 => 134283)
--- trunk/Source/WebCore/platform/graphics/efl/CairoUtilitiesEfl.cpp 2012-11-12 20:34:27 UTC (rev 134282)
+++ trunk/Source/WebCore/platform/graphics/efl/CairoUtilitiesEfl.cpp 2012-11-12 20:37:52 UTC (rev 134283)
@@ -103,7 +103,7 @@
return 0;
}
- return surface;
+ return surface.release();
}
PassRefPtr<cairo_surface_t> createSurfaceForImage(Evas_Object* image)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
