Modified: trunk/Tools/ChangeLog (134307 => 134308)
--- trunk/Tools/ChangeLog 2012-11-12 22:30:01 UTC (rev 134307)
+++ trunk/Tools/ChangeLog 2012-11-12 22:33:40 UTC (rev 134308)
@@ -1,3 +1,24 @@
+2012-11-12 Dirk Pranke <[email protected]>
+
+ nrwt: remove a bunch of broken chromium-specific flags
+ https://bugs.webkit.org/show_bug.cgi?id=101979
+
+ Reviewed by Tony Chang.
+
+ There were a bunch of chromium-specific flags that used to be
+ supported by NRWT (and handled and passed on to DRT) but have
+ probably been broken for a long time and are currently ignored.
+
+ This patch removes all of those flags; the rule of thumb going forward
+ is that we should only add flags that affect how the python code functions.
+ If a flag is just passed verbatim to DRT, the user can use --additional-drt-flag
+ for that.
+
+ * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
+ (parse_args):
+ * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
+ (MainTest.setUp):
+
2012-11-12 Mikhail Pozdnyakov <[email protected]>
[EFL][WK2] Add --device-pixel-ratio command line option to EFL MiniBrowser
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py (134307 => 134308)
--- trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py 2012-11-12 22:30:01 UTC (rev 134307)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py 2012-11-12 22:33:40 UTC (rev 134308)
@@ -207,45 +207,9 @@
# FIXME: These options should move onto the ChromiumPort.
option_group_definitions.append(("Chromium-specific Options", [
- optparse.make_option("--startup-dialog", action=""
- default=False, help="create a dialog on DumpRenderTree startup"),
- optparse.make_option("--gp-fault-error-box", action=""
- default=False, help="enable Windows GP fault error box"),
- optparse.make_option("--js-flags",
- type="string", help="_javascript_ flags to pass to tests"),
- optparse.make_option("--stress-opt", action=""
- default=False,
- help="Enable additional stress test to _javascript_ optimization"),
- optparse.make_option("--stress-deopt", action=""
- default=False,
- help="Enable additional stress test to _javascript_ optimization"),
optparse.make_option("--nocheck-sys-deps", action=""
default=False,
help="Don't check the system dependencies (themes)"),
- optparse.make_option("--accelerated-video",
- action=""
- help="Use hardware-accelerated compositing for video"),
- optparse.make_option("--no-accelerated-video",
- action=""
- dest="accelerated_video",
- help="Don't use hardware-accelerated compositing for video"),
- optparse.make_option("--threaded-compositing",
- action=""
- help="Use threaded compositing for rendering"),
- optparse.make_option("--accelerated-2d-canvas",
- action=""
- help="Use hardware-accelerated 2D Canvas calls"),
- optparse.make_option("--no-accelerated-2d-canvas",
- action=""
- dest="accelerated_2d_canvas",
- help="Don't use hardware-accelerated 2D Canvas calls"),
- optparse.make_option("--accelerated-painting",
- action=""
- default=False,
- help="Use hardware accelerated painting of composited pages"),
- optparse.make_option("--per-tile-painting",
- action=""
- help="Use per-tile painting of composited pages"),
optparse.make_option("--adb-device",
action="" default=[],
help="Run Android layout tests on these devices."),
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py (134307 => 134308)
--- trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py 2012-11-12 22:30:01 UTC (rev 134307)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py 2012-11-12 22:33:40 UTC (rev 134308)
@@ -287,16 +287,6 @@
# properly on cygwin (bug 63846).
self.should_test_processes = not self._platform.is_win()
- def test_accelerated_compositing(self):
- # This just tests that we recognize the command line args
- self.assertTrue(passing_run(['--accelerated-video']))
- self.assertTrue(passing_run(['--no-accelerated-video']))
-
- def test_accelerated_2d_canvas(self):
- # This just tests that we recognize the command line args
- self.assertTrue(passing_run(['--accelerated-2d-canvas']))
- self.assertTrue(passing_run(['--no-accelerated-2d-canvas']))
-
def test_all(self):
res, out, err, user = logging_run([], tests_included=True)
self.assertEquals(res, unexpected_tests_count)
