Title: [134475] trunk
- Revision
- 134475
- Author
- [email protected]
- Date
- 2012-11-13 13:25:18 -0800 (Tue, 13 Nov 2012)
Log Message
WebKit exposes ARIA rowheader role as AXUnknown when not contained in table/grid
https://bugs.webkit.org/show_bug.cgi?id=101616
Reviewed by Beth Dakin.
Source/WebCore:
If the rowheader role is exposed because the element is not within a table, the mac platform
should map that to a generic group.
Test: platform/mac/accessibility/rowheader-outside-table-role.html
* accessibility/mac/WebAccessibilityObjectWrapper.mm:
(createAccessibilityRoleMap):
LayoutTests:
* platform/mac/accessibility/rowheader-outside-table-role-expected.txt: Added.
* platform/mac/accessibility/rowheader-outside-table-role.html: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (134474 => 134475)
--- trunk/LayoutTests/ChangeLog 2012-11-13 21:23:07 UTC (rev 134474)
+++ trunk/LayoutTests/ChangeLog 2012-11-13 21:25:18 UTC (rev 134475)
@@ -1,3 +1,13 @@
+2012-11-13 Chris Fleizach <[email protected]>
+
+ WebKit exposes ARIA rowheader role as AXUnknown when not contained in table/grid
+ https://bugs.webkit.org/show_bug.cgi?id=101616
+
+ Reviewed by Beth Dakin.
+
+ * platform/mac/accessibility/rowheader-outside-table-role-expected.txt: Added.
+ * platform/mac/accessibility/rowheader-outside-table-role.html: Added.
+
2012-11-13 Dirk Pranke <[email protected]>
Remove a few old no-longer-failing tests and update one baseline.
Added: trunk/LayoutTests/platform/mac/accessibility/rowheader-outside-table-role-expected.txt (0 => 134475)
--- trunk/LayoutTests/platform/mac/accessibility/rowheader-outside-table-role-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/mac/accessibility/rowheader-outside-table-role-expected.txt 2012-11-13 21:25:18 UTC (rev 134475)
@@ -0,0 +1,11 @@
+Placeholder content
+This tests that if a rowheader is used outside of a table, it won't have an unknown role.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS rowheader.role is 'AXRole: AXGroup'
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/platform/mac/accessibility/rowheader-outside-table-role.html (0 => 134475)
--- trunk/LayoutTests/platform/mac/accessibility/rowheader-outside-table-role.html (rev 0)
+++ trunk/LayoutTests/platform/mac/accessibility/rowheader-outside-table-role.html 2012-11-13 21:25:18 UTC (rev 134475)
@@ -0,0 +1,27 @@
+<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
+<html>
+<head>
+<script src=""
+</head>
+<body id="body">
+
+<div role="rowheader" id="test">Placeholder content</div>
+
+<p id="description"></p>
+<div id="console"></div>
+
+<script>
+
+ description("This tests that if a rowheader is used outside of a table, it won't have an unknown role.");
+
+ if (window.accessibilityController) {
+
+ var rowheader = accessibilityController.accessibleElementById("test");
+ shouldBe("rowheader.role", "'AXRole: AXGroup'");
+ }
+
+</script>
+
+<script src=""
+</body>
+</html>
Modified: trunk/Source/WebCore/ChangeLog (134474 => 134475)
--- trunk/Source/WebCore/ChangeLog 2012-11-13 21:23:07 UTC (rev 134474)
+++ trunk/Source/WebCore/ChangeLog 2012-11-13 21:25:18 UTC (rev 134475)
@@ -1,3 +1,18 @@
+2012-11-13 Chris Fleizach <[email protected]>
+
+ WebKit exposes ARIA rowheader role as AXUnknown when not contained in table/grid
+ https://bugs.webkit.org/show_bug.cgi?id=101616
+
+ Reviewed by Beth Dakin.
+
+ If the rowheader role is exposed because the element is not within a table, the mac platform
+ should map that to a generic group.
+
+ Test: platform/mac/accessibility/rowheader-outside-table-role.html
+
+ * accessibility/mac/WebAccessibilityObjectWrapper.mm:
+ (createAccessibilityRoleMap):
+
2012-11-13 Stephen White <[email protected]>
[Chromium] Fix SkImageFilter DAG path to pass all css3/filters tests
Modified: trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapper.mm (134474 => 134475)
--- trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapper.mm 2012-11-13 21:23:07 UTC (rev 134474)
+++ trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapper.mm 2012-11-13 21:25:18 UTC (rev 134475)
@@ -1560,6 +1560,7 @@
{ CellRole, NSAccessibilityGroupRole },
#endif
{ TableHeaderContainerRole, NSAccessibilityGroupRole },
+ { RowHeaderRole, NSAccessibilityGroupRole },
{ DefinitionListDefinitionRole, NSAccessibilityGroupRole },
{ DefinitionListTermRole, NSAccessibilityGroupRole },
{ SliderThumbRole, NSAccessibilityValueIndicatorRole },
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
