Title: [134657] trunk/Source/WebCore
- Revision
- 134657
- Author
- [email protected]
- Date
- 2012-11-14 13:26:05 -0800 (Wed, 14 Nov 2012)
Log Message
[WinCairo] Incorrect line-height for styled menulist (select tag)
in windows theme.
https://bugs.webkit.org/show_bug.cgi?id=79435
Patch by Lynn Neir <[email protected]> on 2012-11-14
Reviewed by Brent Fulgham
Applied same fix as in RenderThemeSafari::adjustMenuListButtonStyle
to Windows theme to fix issue.
Tests: fast/forms/menulist-restrict-line-height.html
fast/forms/control-restrict-line-height.html
fast/forms/basic-selects.html
* rendering/RenderThemeWin.cpp:
(WebCore::RenderThemeWin::adjustMenuListButtonStyle): Set line
height to the correct initial height.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (134656 => 134657)
--- trunk/Source/WebCore/ChangeLog 2012-11-14 21:16:41 UTC (rev 134656)
+++ trunk/Source/WebCore/ChangeLog 2012-11-14 21:26:05 UTC (rev 134657)
@@ -1,3 +1,22 @@
+2012-11-14 Lynn Neir <[email protected]>
+
+ [WinCairo] Incorrect line-height for styled menulist (select tag)
+ in windows theme.
+ https://bugs.webkit.org/show_bug.cgi?id=79435
+
+ Reviewed by Brent Fulgham
+
+ Applied same fix as in RenderThemeSafari::adjustMenuListButtonStyle
+ to Windows theme to fix issue.
+
+ Tests: fast/forms/menulist-restrict-line-height.html
+ fast/forms/control-restrict-line-height.html
+ fast/forms/basic-selects.html
+
+ * rendering/RenderThemeWin.cpp:
+ (WebCore::RenderThemeWin::adjustMenuListButtonStyle): Set line
+ height to the correct initial height.
+
2012-11-14 Erik Arvidsson <[email protected]>
Update DOMException name: WrongDocumentError
Modified: trunk/Source/WebCore/rendering/RenderThemeWin.cpp (134656 => 134657)
--- trunk/Source/WebCore/rendering/RenderThemeWin.cpp 2012-11-14 21:16:41 UTC (rev 134656)
+++ trunk/Source/WebCore/rendering/RenderThemeWin.cpp 2012-11-14 21:26:05 UTC (rev 134657)
@@ -785,6 +785,8 @@
minHeight = max(minHeight, dropDownBoxMinHeight);
style->setMinHeight(Length(minHeight, Fixed));
+
+ style->setLineHeight(RenderStyle::initialLineHeight());
// White-space is locked to pre
style->setWhiteSpace(PRE);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
