Title: [134790] trunk/Source/WebCore
- Revision
- 134790
- Author
- [email protected]
- Date
- 2012-11-15 10:13:54 -0800 (Thu, 15 Nov 2012)
Log Message
Remove isHTMLInputElement since it's unused and toInputElement exists
https://bugs.webkit.org/show_bug.cgi?id=102358
Patch by Elliott Sprehn <[email protected]> on 2012-11-15
Reviewed by Ojan Vafai.
Remove isHTMLInputElement as no one uses it. Everyone just uses
Node::toInputElement and checks for a 0 return value instead.
toInputElement is also more reliable as there's no requirement that
subclasses of HTMLInputElement have the tag name of inputTag so using
this method in a check could potentially miss future subclasses with
different tag names, though none exist right now.
No new tests, this just deletes dead code.
* html/HTMLInputElement.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (134789 => 134790)
--- trunk/Source/WebCore/ChangeLog 2012-11-15 18:13:15 UTC (rev 134789)
+++ trunk/Source/WebCore/ChangeLog 2012-11-15 18:13:54 UTC (rev 134790)
@@ -1,3 +1,22 @@
+2012-11-15 Elliott Sprehn <[email protected]>
+
+ Remove isHTMLInputElement since it's unused and toInputElement exists
+ https://bugs.webkit.org/show_bug.cgi?id=102358
+
+ Reviewed by Ojan Vafai.
+
+ Remove isHTMLInputElement as no one uses it. Everyone just uses
+ Node::toInputElement and checks for a 0 return value instead.
+
+ toInputElement is also more reliable as there's no requirement that
+ subclasses of HTMLInputElement have the tag name of inputTag so using
+ this method in a check could potentially miss future subclasses with
+ different tag names, though none exist right now.
+
+ No new tests, this just deletes dead code.
+
+ * html/HTMLInputElement.h:
+
2012-11-15 Erik Arvidsson <[email protected]>
Update DOMException name: NoModificationAllowedError
Modified: trunk/Source/WebCore/html/HTMLInputElement.h (134789 => 134790)
--- trunk/Source/WebCore/html/HTMLInputElement.h 2012-11-15 18:13:15 UTC (rev 134789)
+++ trunk/Source/WebCore/html/HTMLInputElement.h 2012-11-15 18:13:54 UTC (rev 134790)
@@ -431,11 +431,5 @@
#endif
};
-inline bool isHTMLInputElement(Node* node)
-{
- ASSERT(node);
- return node->hasTagName(HTMLNames::inputTag);
-}
-
} //namespace
#endif
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
