Title: [134842] trunk/Source/WebCore
- Revision
- 134842
- Author
- [email protected]
- Date
- 2012-11-15 15:43:15 -0800 (Thu, 15 Nov 2012)
Log Message
ASSERTION FAILED: fastAttributeLookupAllowed(name) for 7 layout tests
<http://webkit.org/b/102423>
Reviewed by Anders Carlsson.
Use Element::getAttributeItem() to find out if the element has a given attribute
instead of fastHasAttribute() since that causes assertions for the "style" attribute.
* html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::mergeAttributesFromTokenIntoElement):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (134841 => 134842)
--- trunk/Source/WebCore/ChangeLog 2012-11-15 23:33:29 UTC (rev 134841)
+++ trunk/Source/WebCore/ChangeLog 2012-11-15 23:43:15 UTC (rev 134842)
@@ -1,3 +1,16 @@
+2012-11-15 Andreas Kling <[email protected]>
+
+ ASSERTION FAILED: fastAttributeLookupAllowed(name) for 7 layout tests
+ <http://webkit.org/b/102423>
+
+ Reviewed by Anders Carlsson.
+
+ Use Element::getAttributeItem() to find out if the element has a given attribute
+ instead of fastHasAttribute() since that causes assertions for the "style" attribute.
+
+ * html/parser/HTMLConstructionSite.cpp:
+ (WebCore::HTMLConstructionSite::mergeAttributesFromTokenIntoElement):
+
2012-11-15 Erik Arvidsson <[email protected]>
Update DOMException name: DOMStringSizeError
Modified: trunk/Source/WebCore/html/parser/HTMLConstructionSite.cpp (134841 => 134842)
--- trunk/Source/WebCore/html/parser/HTMLConstructionSite.cpp 2012-11-15 23:33:29 UTC (rev 134841)
+++ trunk/Source/WebCore/html/parser/HTMLConstructionSite.cpp 2012-11-15 23:43:15 UTC (rev 134842)
@@ -199,7 +199,7 @@
for (unsigned i = 0; i < token->attributes().size(); ++i) {
const Attribute& tokenAttribute = token->attributes().at(i);
- if (!element->fastHasAttribute(tokenAttribute.name()))
+ if (!element->attributeData() || !element->getAttributeItem(tokenAttribute.name()))
element->setAttribute(tokenAttribute.name(), tokenAttribute.value());
}
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
