Title: [134852] trunk/Source/WebKit/chromium
- Revision
- 134852
- Author
- [email protected]
- Date
- 2012-11-15 16:23:13 -0800 (Thu, 15 Nov 2012)
Log Message
Ignore autocomplete=off for chrome generated passwords.
https://bugs.webkit.org/show_bug.cgi?id=102426
Patch by Yue Zhang <[email protected]> on 2012-11-15
Reviewed by Adam Barth.
Record the autocomplete attribute in the web password form data,
so that we can handle autocomplete in chromium code. The
motivation/background is: we should ignore autocomplete=off field
for password forms with chrome generated passwords (has passed
security review). By handling autocomplete in chromium code we can
distinguish password forms with chrome generated passwords and
those normal password forms. Note that we haven't turned off
checking autocomplete=off in the Webkit code for now so there is
no behavior change after this CL, and we will turn off after we
make the chromium side change to be safe.
* public/WebPasswordFormData.h:
(WebPasswordFormData):
* src/WebPasswordFormData.cpp:
Modified Paths
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (134851 => 134852)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-11-16 00:22:02 UTC (rev 134851)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-11-16 00:23:13 UTC (rev 134852)
@@ -1,3 +1,25 @@
+2012-11-15 Yue Zhang <[email protected]>
+
+ Ignore autocomplete=off for chrome generated passwords.
+ https://bugs.webkit.org/show_bug.cgi?id=102426
+
+ Reviewed by Adam Barth.
+
+ Record the autocomplete attribute in the web password form data,
+ so that we can handle autocomplete in chromium code. The
+ motivation/background is: we should ignore autocomplete=off field
+ for password forms with chrome generated passwords (has passed
+ security review). By handling autocomplete in chromium code we can
+ distinguish password forms with chrome generated passwords and
+ those normal password forms. Note that we haven't turned off
+ checking autocomplete=off in the Webkit code for now so there is
+ no behavior change after this CL, and we will turn off after we
+ make the chromium side change to be safe.
+
+ * public/WebPasswordFormData.h:
+ (WebPasswordFormData):
+ * src/WebPasswordFormData.cpp:
+
2012-11-15 Scott Violet <[email protected]>
[chromium] Create default directory so that cq can apply patch
Modified: trunk/Source/WebKit/chromium/public/WebPasswordFormData.h (134851 => 134852)
--- trunk/Source/WebKit/chromium/public/WebPasswordFormData.h 2012-11-16 00:22:02 UTC (rev 134851)
+++ trunk/Source/WebKit/chromium/public/WebPasswordFormData.h 2012-11-16 00:23:13 UTC (rev 134852)
@@ -97,12 +97,20 @@
// When parsing an HTML form, this is typically empty.
WebString passwordValue;
+ // Value of shouldAutocomplete for the password element.
+ bool passwordShouldAutocomplete;
+
// If the form was a change password form, the name of the
// 'old password' input element. Optional.
WebString oldPasswordElement;
// The old password. Optional.
WebString oldPasswordValue;
+
+ WebPasswordFormData()
+ : passwordShouldAutocomplete(false)
+ {
+ }
};
} // namespace WebKit
Modified: trunk/Source/WebKit/chromium/src/WebPasswordFormData.cpp (134851 => 134852)
--- trunk/Source/WebKit/chromium/src/WebPasswordFormData.cpp 2012-11-16 00:22:02 UTC (rev 134851)
+++ trunk/Source/WebKit/chromium/src/WebPasswordFormData.cpp 2012-11-16 00:23:13 UTC (rev 134852)
@@ -138,6 +138,7 @@
if (password) {
result->passwordElement = password->name();
result->passwordValue = password->value();
+ result->passwordShouldAutocomplete = password->shouldAutocomplete();
}
if (oldPassword) {
result->oldPasswordElement = oldPassword->name();
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
