Title: [135219] trunk/Source/WebCore
- Revision
- 135219
- Author
- aba...@webkit.org
- Date
- 2012-11-19 17:52:01 -0800 (Mon, 19 Nov 2012)
Log Message
DISALLOW_COPY_AND_ASSIGN is not a WebKit macro
https://bugs.webkit.org/show_bug.cgi?id=102755
Reviewed by Sam Weinig.
WTF_MAKE_NONCOPYABLE is the idiom we use in WebKit. I don't understand
how this compiles.
* Modules/indexeddb/IDBBackingStore.h:
(RecordIdentifier):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (135218 => 135219)
--- trunk/Source/WebCore/ChangeLog 2012-11-20 01:46:16 UTC (rev 135218)
+++ trunk/Source/WebCore/ChangeLog 2012-11-20 01:52:01 UTC (rev 135219)
@@ -1,3 +1,16 @@
+2012-11-19 Adam Barth <aba...@webkit.org>
+
+ DISALLOW_COPY_AND_ASSIGN is not a WebKit macro
+ https://bugs.webkit.org/show_bug.cgi?id=102755
+
+ Reviewed by Sam Weinig.
+
+ WTF_MAKE_NONCOPYABLE is the idiom we use in WebKit. I don't understand
+ how this compiles.
+
+ * Modules/indexeddb/IDBBackingStore.h:
+ (RecordIdentifier):
+
2012-11-19 Chris Rogers <crog...@google.com>
Implement .detune attribute for BiquadFilterNode
Modified: trunk/Source/WebCore/Modules/indexeddb/IDBBackingStore.h (135218 => 135219)
--- trunk/Source/WebCore/Modules/indexeddb/IDBBackingStore.h 2012-11-20 01:46:16 UTC (rev 135218)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBBackingStore.h 2012-11-20 01:52:01 UTC (rev 135219)
@@ -62,6 +62,7 @@
virtual void deleteObjectStore(IDBBackingStore::Transaction*, int64_t databaseId, int64_t objectStoreId);
class RecordIdentifier {
+ WTF_MAKE_NONCOPYABLE(RecordIdentifier);
public:
RecordIdentifier(const Vector<char>& primaryKey, int64_t version) : m_primaryKey(primaryKey), m_version(version) { ASSERT(!primaryKey.isEmpty()); }
RecordIdentifier() : m_primaryKey(), m_version(-1) { }
@@ -73,7 +74,6 @@
private:
Vector<char> m_primaryKey; // FIXME: Make it more clear that this is the *encoded* version of the key.
int64_t m_version;
- DISALLOW_COPY_AND_ASSIGN(RecordIdentifier);
};
virtual String getRecord(IDBBackingStore::Transaction*, int64_t databaseId, int64_t objectStoreId, const IDBKey&);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
