Title: [135398] trunk/Tools
- Revision
- 135398
- Author
- commit-qu...@webkit.org
- Date
- 2012-11-21 07:07:55 -0800 (Wed, 21 Nov 2012)
Log Message
[EFL] KURL unit test crashing when tiled backing store is enabled on Release Bots
https://bugs.webkit.org/show_bug.cgi?id=102895
Patch by Thiago Marcos P. Santos <thiago.san...@intel.com> on 2012-11-21
Reviewed by Gyuyoung Kim.
Change the link order so it wont override the new operator on gtest.
Looks like it was crashing because an allocator mismatch (using libc's
new and later fastMalloc delete. Thanks to Kangil Han for hinting on
the fastMalloc issue.
* TestWebKitAPI/CMakeLists.txt:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (135397 => 135398)
--- trunk/Tools/ChangeLog 2012-11-21 14:46:44 UTC (rev 135397)
+++ trunk/Tools/ChangeLog 2012-11-21 15:07:55 UTC (rev 135398)
@@ -1,3 +1,17 @@
+2012-11-21 Thiago Marcos P. Santos <thiago.san...@intel.com>
+
+ [EFL] KURL unit test crashing when tiled backing store is enabled on Release Bots
+ https://bugs.webkit.org/show_bug.cgi?id=102895
+
+ Reviewed by Gyuyoung Kim.
+
+ Change the link order so it wont override the new operator on gtest.
+ Looks like it was crashing because an allocator mismatch (using libc's
+ new and later fastMalloc delete. Thanks to Kangil Han for hinting on
+ the fastMalloc issue.
+
+ * TestWebKitAPI/CMakeLists.txt:
+
2012-11-21 Kentaro Hara <hara...@chromium.org>
Unreviewed, rolling out r135340.
Modified: trunk/Tools/TestWebKitAPI/CMakeLists.txt (135397 => 135398)
--- trunk/Tools/TestWebKitAPI/CMakeLists.txt 2012-11-21 14:46:44 UTC (rev 135397)
+++ trunk/Tools/TestWebKitAPI/CMakeLists.txt 2012-11-21 15:07:55 UTC (rev 135398)
@@ -94,17 +94,15 @@
SET_TESTS_PROPERTIES(test_wtf PROPERTIES TIMEOUT 60)
SET(test_webcore_LIBRARIES
+ gtest
${WTF_LIBRARY_NAME}
${WebCore_LIBRARY_NAME}
- gtest
)
ADD_EXECUTABLE(test_webcore
${test_main_SOURCES}
${TESTWEBKITAPI_DIR}/TestsController.cpp
-# FIXME: This code inclusion makes API test crash (test_webcore) when tiled backing store is enabled.
-# https://bugs.webkit.org/show_bug.cgi?id=102895 is filed for the crash.
-# ${TESTWEBKITAPI_DIR}/Tests/WebCore/KURL.cpp
+ ${TESTWEBKITAPI_DIR}/Tests/WebCore/KURL.cpp
)
TARGET_LINK_LIBRARIES(test_webcore ${test_webcore_LIBRARIES})
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
