Title: [135412] trunk/Source/WebCore
- Revision
- 135412
- Author
- [email protected]
- Date
- 2012-11-21 09:34:21 -0800 (Wed, 21 Nov 2012)
Log Message
Web Inspector: Ctrl+A closes breakpoint condition editor
https://bugs.webkit.org/show_bug.cgi?id=102906
Patch by Andrey Lushnikov <[email protected]> on 2012-11-21
Reviewed by Pavel Feldman.
Check if e.target has no ancestors with className
"webkit-line-decorations" in DefaultTextEditor._handleKeyDown
* inspector/front-end/DefaultTextEditor.js:
(WebInspector.DefaultTextEditor.prototype._handleKeyDown): Add check
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (135411 => 135412)
--- trunk/Source/WebCore/ChangeLog 2012-11-21 17:28:05 UTC (rev 135411)
+++ trunk/Source/WebCore/ChangeLog 2012-11-21 17:34:21 UTC (rev 135412)
@@ -1,3 +1,16 @@
+2012-11-21 Andrey Lushnikov <[email protected]>
+
+ Web Inspector: Ctrl+A closes breakpoint condition editor
+ https://bugs.webkit.org/show_bug.cgi?id=102906
+
+ Reviewed by Pavel Feldman.
+
+ Check if e.target has no ancestors with className
+ "webkit-line-decorations" in DefaultTextEditor._handleKeyDown
+
+ * inspector/front-end/DefaultTextEditor.js:
+ (WebInspector.DefaultTextEditor.prototype._handleKeyDown): Add check
+
2012-11-21 Tom Hudson <[email protected]>
Avoid creating degenerate cubics at corners of rounded rects.
Modified: trunk/Source/WebCore/inspector/front-end/DefaultTextEditor.js (135411 => 135412)
--- trunk/Source/WebCore/inspector/front-end/DefaultTextEditor.js 2012-11-21 17:28:05 UTC (rev 135411)
+++ trunk/Source/WebCore/inspector/front-end/DefaultTextEditor.js 2012-11-21 17:34:21 UTC (rev 135412)
@@ -417,6 +417,11 @@
_handleKeyDown: function(e)
{
+ // If the event was not triggered from the entire editor, then
+ // ignore it. https://bugs.webkit.org/show_bug.cgi?id=102906
+ if (e.target.enclosingNodeOrSelfWithClass("webkit-line-decorations"))
+ return;
+
var shortcutKey = WebInspector.KeyboardShortcut.makeKeyFromEvent(e);
var handler = this._shortcuts[shortcutKey];
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
