Title: [135427] trunk/Source/WebKit/blackberry
- Revision
- 135427
- Author
- [email protected]
- Date
- 2012-11-21 12:37:10 -0800 (Wed, 21 Nov 2012)
Log Message
[BlackBerry] Don't add empty rects to the tap highlight region.
https://bugs.webkit.org/show_bug.cgi?id=102966
Reviewed by George Staikos.
Internal PR 246960
Tap highlight is way too large sometimes.
When we add an empty rect it inflates by 2 and causes the tap region to extend to the origin.
* WebKitSupport/TouchEventHandler.cpp:
(BlackBerry::WebKit::TouchEventHandler::drawTapHighlight):
Modified Paths
Diff
Modified: trunk/Source/WebKit/blackberry/ChangeLog (135426 => 135427)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-11-21 20:29:21 UTC (rev 135426)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-11-21 20:37:10 UTC (rev 135427)
@@ -1,3 +1,17 @@
+2012-11-21 Konrad Piascik <[email protected]>
+
+ [BlackBerry] Don't add empty rects to the tap highlight region.
+ https://bugs.webkit.org/show_bug.cgi?id=102966
+
+ Reviewed by George Staikos.
+
+ Internal PR 246960
+ Tap highlight is way too large sometimes.
+ When we add an empty rect it inflates by 2 and causes the tap region to extend to the origin.
+
+ * WebKitSupport/TouchEventHandler.cpp:
+ (BlackBerry::WebKit::TouchEventHandler::drawTapHighlight):
+
2012-11-21 Mike Fenton <[email protected]>
[BlackBerry] Switch to point instead of VisiblePosition comparison for input bounds check
Modified: trunk/Source/WebKit/blackberry/WebKitSupport/TouchEventHandler.cpp (135426 => 135427)
--- trunk/Source/WebKit/blackberry/WebKitSupport/TouchEventHandler.cpp 2012-11-21 20:29:21 UTC (rev 135426)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/TouchEventHandler.cpp 2012-11-21 20:37:10 UTC (rev 135427)
@@ -402,6 +402,9 @@
IntRect rect = focusRingQuads[i].enclosingBoundingBox();
rect.move(framePos.x(), framePos.y());
IntRect clippedRect = intersection(clippingRect, rect);
+ // FIXME we shouldn't have any empty rects here PR 246960
+ if (clippedRect.isEmpty())
+ continue;
clippedRect.inflate(2);
region = unionRegions(region, Platform::IntRect(clippedRect));
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
