Title: [135547] trunk/Source/WebCore
Revision
135547
Author
[email protected]
Date
2012-11-22 15:12:13 -0800 (Thu, 22 Nov 2012)

Log Message

Remove 'module' from IDL parser
https://bugs.webkit.org/show_bug.cgi?id=102670

Reviewed by Adam Barth.

The Web IDL spec no longer supports 'module'. We already removed
'module's from WebKit IDL files. So this patch removes 'module'
from the IDL parser.

No tests. No change in behavior.

* bindings/scripts/IDLParser.pm:
(Parse):
(parseDefinitionOld):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (135546 => 135547)


--- trunk/Source/WebCore/ChangeLog	2012-11-22 23:02:53 UTC (rev 135546)
+++ trunk/Source/WebCore/ChangeLog	2012-11-22 23:12:13 UTC (rev 135547)
@@ -1,3 +1,20 @@
+2012-11-22  Kentaro Hara  <[email protected]>
+
+        Remove 'module' from IDL parser
+        https://bugs.webkit.org/show_bug.cgi?id=102670
+
+        Reviewed by Adam Barth.
+
+        The Web IDL spec no longer supports 'module'. We already removed
+        'module's from WebKit IDL files. So this patch removes 'module'
+        from the IDL parser.
+
+        No tests. No change in behavior.
+
+        * bindings/scripts/IDLParser.pm:
+        (Parse):
+        (parseDefinitionOld):
+
 2012-11-22  Dan Carney  <[email protected]>
 
         [V8] fix DOMWrapperWorld destructor

Modified: trunk/Source/WebCore/bindings/scripts/IDLParser.pm (135546 => 135547)


--- trunk/Source/WebCore/bindings/scripts/IDLParser.pm	2012-11-22 23:02:53 UTC (rev 135546)
+++ trunk/Source/WebCore/bindings/scripts/IDLParser.pm	2012-11-22 23:12:13 UTC (rev 135547)
@@ -35,14 +35,13 @@
 
 # Used to represent a parsed IDL document
 struct( idlDocument => {
-    module => '$',   # Module identifier
     interfaces => '@',  # All parsed interfaces
     fileName => '$'  # file name
 });
 
 # Used to represent 'interface' blocks
 struct( domInterface => {
-    name => '$',      # Class identifier (without module)
+    name => '$',      # Class identifier
     parents => '@',      # List of strings
     constants => '@',    # List of 'domConstant'
     functions => '@',    # List of 'domFunction'
@@ -173,7 +172,6 @@
         $document = $definitions[0];
     } else {
         $document = idlDocument->new();
-        $document->module("");
         push(@{$document->interfaces}, @definitions);
     }
 
@@ -2069,36 +2067,12 @@
     if ($next->value() eq "typedef") {
         return $self->parseTypedef({});
     }
-    if ($next->value() eq "module") {
-        return $self->parseModule();
-    }
     if ($next->type() == IdentifierToken || $next->value() eq "::") {
         return $self->parseImplementsStatement({});
     }
     $self->assertUnexpectedToken($next->value(), __LINE__);
 }
 
-sub parseModule
-{
-    my $self = shift;
-    my $next = $self->nextToken();
-    if ($next->value() eq "module") {
-        my $document = idlDocument->new();
-        $self->assertTokenValue($self->getToken(), "module", __LINE__);
-        my $extendedAttributeList = $self->parseExtendedAttributeListAllowEmpty();
-        my $token = $self->getToken();
-        $self->assertTokenType($token, IdentifierToken);
-        $self->assertTokenValue($self->getToken(), "{", __LINE__);
-        $document->module($token->value());
-        my $definitions = $self->parseDefinitions();
-        push(@{$document->interfaces}, @{$definitions});
-        $self->assertTokenValue($self->getToken(), "}", __LINE__);
-        $self->parseOptionalSemicolon();
-        return $document;
-    }
-    $self->assertUnexpectedToken($next->value(), __LINE__);
-}
-
 sub parseCallbackOrInterfaceOld
 {
     my $self = shift;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to