Title: [135562] trunk
Revision
135562
Author
[email protected]
Date
2012-11-22 23:44:43 -0800 (Thu, 22 Nov 2012)

Log Message

window is missing Touch and TouchList - touch event conformance test failure
https://bugs.webkit.org/show_bug.cgi?id=96295

Patch by Rick Byers <[email protected]> on 2012-11-22
Reviewed by Adam Barth.

Source/WebCore:

Add Touch and TouchList constructors to window for ENABLE(TOUCH_EVENTS).

Tests: fast/js/global-constructors.html
       fast/events/touch/document-create-touch-list.html

* page/DOMWindow.idl:

LayoutTests:

* fast/events/touch/document-create-touch-list-expected.txt:
* fast/events/touch/script-tests/document-create-touch-list.js: Add instanceof checks
* platform/efl/fast/js/global-constructors-expected.txt: Add new expected constructors
* platform/qt-5.0/fast/js/global-constructors-expected.txt: Add new expected constructors
* platform/qt/fast/js/global-constructors-expected.txt: Add new expected constructors

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (135561 => 135562)


--- trunk/LayoutTests/ChangeLog	2012-11-23 07:35:03 UTC (rev 135561)
+++ trunk/LayoutTests/ChangeLog	2012-11-23 07:44:43 UTC (rev 135562)
@@ -1,3 +1,16 @@
+2012-11-22  Rick Byers <[email protected]>
+
+        window is missing Touch and TouchList - touch event conformance test failure
+        https://bugs.webkit.org/show_bug.cgi?id=96295
+
+        Reviewed by Adam Barth.
+
+        * fast/events/touch/document-create-touch-list-expected.txt:
+        * fast/events/touch/script-tests/document-create-touch-list.js: Add instanceof checks
+        * platform/efl/fast/js/global-constructors-expected.txt: Add new expected constructors
+        * platform/qt-5.0/fast/js/global-constructors-expected.txt: Add new expected constructors
+        * platform/qt/fast/js/global-constructors-expected.txt: Add new expected constructors
+
 2012-11-22  Yury Semikhatsky  <[email protected]>
 
         Unreviewed. Test expectations update after Skia changes.

Modified: trunk/LayoutTests/fast/events/touch/document-create-touch-list-expected.txt (135561 => 135562)


--- trunk/LayoutTests/fast/events/touch/document-create-touch-list-expected.txt	2012-11-23 07:35:03 UTC (rev 135561)
+++ trunk/LayoutTests/fast/events/touch/document-create-touch-list-expected.txt	2012-11-23 07:44:43 UTC (rev 135562)
@@ -9,7 +9,10 @@
 PASS touchList.item(0) is null
 PASS touchList.item(1) is null
 PASS touchList.item() threw exception TypeError: Not enough arguments.
+PASS ts instanceof TouchEvent is true
+PASS ts.touches instanceof TouchList is true
 PASS ts.touches.length is 2
+PASS ts.touches[0] instanceof Touch is true
 PASS ts.touches[0].identifier is 12341
 PASS ts.touches[0].clientX is 60
 PASS ts.touches[1].screenY is 120

Modified: trunk/LayoutTests/fast/events/touch/script-tests/document-create-touch-list.js (135561 => 135562)


--- trunk/LayoutTests/fast/events/touch/script-tests/document-create-touch-list.js	2012-11-23 07:35:03 UTC (rev 135561)
+++ trunk/LayoutTests/fast/events/touch/script-tests/document-create-touch-list.js	2012-11-23 07:44:43 UTC (rev 135562)
@@ -21,7 +21,10 @@
 
     document.body.addEventListener("touchstart", function handleTouchStart(ev) {
         ts = ev;
+        shouldBeTrue("ts instanceof TouchEvent");
+        shouldBeTrue("ts.touches instanceof TouchList");
         shouldBe("ts.touches.length", "2");
+        shouldBeTrue("ts.touches[0] instanceof Touch");
         shouldBe("ts.touches[0].identifier", "12341");
         shouldBe("ts.touches[0].clientX", "60");
         shouldBe("ts.touches[1].screenY", "120");

Modified: trunk/LayoutTests/platform/efl/fast/js/global-constructors-expected.txt (135561 => 135562)


--- trunk/LayoutTests/platform/efl/fast/js/global-constructors-expected.txt	2012-11-23 07:35:03 UTC (rev 135561)
+++ trunk/LayoutTests/platform/efl/fast/js/global-constructors-expected.txt	2012-11-23 07:44:43 UTC (rev 135562)
@@ -318,7 +318,9 @@
 PASS TextTrackCueList.toString() is '[object TextTrackCueListConstructor]'
 PASS TextTrackList.toString() is '[object TextTrackListConstructor]'
 PASS TimeRanges.toString() is '[object TimeRangesConstructor]'
+PASS Touch.toString() is '[object TouchConstructor]'
 PASS TouchEvent.toString() is '[object TouchEventConstructor]'
+PASS TouchList.toString() is '[object TouchListConstructor]'
 PASS TrackEvent.toString() is '[object TrackEventConstructor]'
 PASS UIEvent.toString() is '[object UIEventConstructor]'
 PASS URL.toString() is '[object URLConstructor]'

Modified: trunk/LayoutTests/platform/qt/fast/js/global-constructors-expected.txt (135561 => 135562)


--- trunk/LayoutTests/platform/qt/fast/js/global-constructors-expected.txt	2012-11-23 07:35:03 UTC (rev 135561)
+++ trunk/LayoutTests/platform/qt/fast/js/global-constructors-expected.txt	2012-11-23 07:44:43 UTC (rev 135562)
@@ -295,7 +295,9 @@
 PASS TextEvent.toString() is '[object TextEventConstructor]'
 PASS TextMetrics.toString() is '[object TextMetricsConstructor]'
 PASS TimeRanges.toString() is '[object TimeRangesConstructor]'
+PASS Touch.toString() is '[object TouchConstructor]'
 PASS TouchEvent.toString() is '[object TouchEventConstructor]'
+PASS TouchList.toString() is '[object TouchListConstructor]'
 PASS UIEvent.toString() is '[object UIEventConstructor]'
 PASS WebGLContextEvent.toString() is '[object WebGLContextEventConstructor]'
 PASS WebKitAnimationEvent.toString() is '[object WebKitAnimationEventConstructor]'

Modified: trunk/LayoutTests/platform/qt-5.0/fast/js/global-constructors-expected.txt (135561 => 135562)


--- trunk/LayoutTests/platform/qt-5.0/fast/js/global-constructors-expected.txt	2012-11-23 07:35:03 UTC (rev 135561)
+++ trunk/LayoutTests/platform/qt-5.0/fast/js/global-constructors-expected.txt	2012-11-23 07:44:43 UTC (rev 135562)
@@ -311,7 +311,9 @@
 PASS TextEvent.toString() is '[object TextEventConstructor]'
 PASS TextMetrics.toString() is '[object TextMetricsConstructor]'
 PASS TimeRanges.toString() is '[object TimeRangesConstructor]'
+PASS Touch.toString() is '[object TouchConstructor]'
 PASS TouchEvent.toString() is '[object TouchEventConstructor]'
+PASS TouchList.toString() is '[object TouchListConstructor]'
 PASS UIEvent.toString() is '[object UIEventConstructor]'
 PASS URL.toString() is '[object URLConstructor]'
 PASS WebGLContextEvent.toString() is '[object WebGLContextEventConstructor]'

Modified: trunk/Source/WebCore/ChangeLog (135561 => 135562)


--- trunk/Source/WebCore/ChangeLog	2012-11-23 07:35:03 UTC (rev 135561)
+++ trunk/Source/WebCore/ChangeLog	2012-11-23 07:44:43 UTC (rev 135562)
@@ -1,3 +1,17 @@
+2012-11-22  Rick Byers  <[email protected]>
+
+        window is missing Touch and TouchList - touch event conformance test failure
+        https://bugs.webkit.org/show_bug.cgi?id=96295
+
+        Reviewed by Adam Barth.
+
+        Add Touch and TouchList constructors to window for ENABLE(TOUCH_EVENTS).
+
+        Tests: fast/js/global-constructors.html
+               fast/events/touch/document-create-touch-list.html
+
+        * page/DOMWindow.idl:
+
 2012-11-22  Dan Carney  <[email protected]>
 
         [V8] Make worker context prototype chain match other browsers

Modified: trunk/Source/WebCore/page/DOMWindow.idl (135561 => 135562)


--- trunk/Source/WebCore/page/DOMWindow.idl	2012-11-23 07:35:03 UTC (rev 135561)
+++ trunk/Source/WebCore/page/DOMWindow.idl	2012-11-23 07:44:43 UTC (rev 135562)
@@ -554,7 +554,9 @@
     attribute XMLHttpRequestProgressEventConstructor XMLHttpRequestProgressEvent;
     [Conditional=DEVICE_ORIENTATION, V8EnabledAtRuntime] attribute DeviceMotionEventConstructor DeviceMotionEvent;
     [Conditional=DEVICE_ORIENTATION, V8EnabledAtRuntime] attribute DeviceOrientationEventConstructor DeviceOrientationEvent;
+    [Conditional=TOUCH_EVENTS] attribute TouchConstructor Touch;
     [Conditional=TOUCH_EVENTS] attribute TouchEventConstructor TouchEvent;
+    [Conditional=TOUCH_EVENTS] attribute TouchListConstructor TouchList;
     attribute StorageEventConstructor StorageEvent;
     [Conditional=INPUT_SPEECH] attribute SpeechInputEventConstructor SpeechInputEvent;
     [Conditional=WEBGL] attribute WebGLContextEventConstructor WebGLContextEvent;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to