Title: [135571] trunk/Source/WebCore
- Revision
- 135571
- Author
- [email protected]
- Date
- 2012-11-23 01:45:26 -0800 (Fri, 23 Nov 2012)
Log Message
Web Inspector: inspector overlay is always updated when inspector is open
https://bugs.webkit.org/show_bug.cgi?id=103106
Reviewed by Pavel Feldman.
Provide empty size into the InspectorOverlay if the metrics emulation is disabled,
so that it will not get painted in all cases.
* inspector/InspectorController.cpp:
(WebCore::InspectorController::webViewResized): Call InspectorPageAgent::webViewResized() rather than InspectorOverlay::resize().
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::webViewResized): Provide empty size into InspectorOverlay::resize() if device metrics are not emulated.
* inspector/InspectorPageAgent.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (135570 => 135571)
--- trunk/Source/WebCore/ChangeLog 2012-11-23 09:29:34 UTC (rev 135570)
+++ trunk/Source/WebCore/ChangeLog 2012-11-23 09:45:26 UTC (rev 135571)
@@ -1,3 +1,19 @@
+2012-11-23 Alexander Pavlov <[email protected]>
+
+ Web Inspector: inspector overlay is always updated when inspector is open
+ https://bugs.webkit.org/show_bug.cgi?id=103106
+
+ Reviewed by Pavel Feldman.
+
+ Provide empty size into the InspectorOverlay if the metrics emulation is disabled,
+ so that it will not get painted in all cases.
+
+ * inspector/InspectorController.cpp:
+ (WebCore::InspectorController::webViewResized): Call InspectorPageAgent::webViewResized() rather than InspectorOverlay::resize().
+ * inspector/InspectorPageAgent.cpp:
+ (WebCore::InspectorPageAgent::webViewResized): Provide empty size into InspectorOverlay::resize() if device metrics are not emulated.
+ * inspector/InspectorPageAgent.h:
+
2012-11-23 Krzysztof Czech <[email protected]>
[EFL] Platform support for Accessibility feature.
Modified: trunk/Source/WebCore/inspector/InspectorController.cpp (135570 => 135571)
--- trunk/Source/WebCore/inspector/InspectorController.cpp 2012-11-23 09:29:34 UTC (rev 135570)
+++ trunk/Source/WebCore/inspector/InspectorController.cpp 2012-11-23 09:45:26 UTC (rev 135571)
@@ -293,7 +293,7 @@
void InspectorController::webViewResized(const IntSize& size)
{
- m_overlay->resize(size);
+ m_pageAgent->webViewResized(size);
}
void InspectorController::evaluateForTestInFrontend(long callId, const String& script)
Modified: trunk/Source/WebCore/inspector/InspectorPageAgent.cpp (135570 => 135571)
--- trunk/Source/WebCore/inspector/InspectorPageAgent.cpp 2012-11-23 09:29:34 UTC (rev 135570)
+++ trunk/Source/WebCore/inspector/InspectorPageAgent.cpp 2012-11-23 09:45:26 UTC (rev 135571)
@@ -373,6 +373,12 @@
}
}
+void InspectorPageAgent::webViewResized(const IntSize& size)
+{
+ int currentWidth = static_cast<int>(m_state->getLong(PageAgentState::pageAgentScreenWidthOverride));
+ m_overlay->resize(currentWidth ? size : IntSize());
+}
+
void InspectorPageAgent::enable(ErrorString*)
{
m_enabled = true;
Modified: trunk/Source/WebCore/inspector/InspectorPageAgent.h (135570 => 135571)
--- trunk/Source/WebCore/inspector/InspectorPageAgent.h 2012-11-23 09:29:34 UTC (rev 135570)
+++ trunk/Source/WebCore/inspector/InspectorPageAgent.h 2012-11-23 09:45:26 UTC (rev 135571)
@@ -148,6 +148,8 @@
virtual void clearFrontend();
virtual void restore();
+ void webViewResized(const IntSize&);
+
// Cross-agents API
Frame* mainFrame();
String createIdentifier();
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
