Title: [135594] trunk/Source/WebKit/blackberry
- Revision
- 135594
- Author
- [email protected]
- Date
- 2012-11-23 04:54:53 -0800 (Fri, 23 Nov 2012)
Log Message
[BlackBerry] InputHandler::ensureFocusTextElementVisible incorrectly used y coordinate as x coordinate
https://bugs.webkit.org/show_bug.cgi?id=103091
Patch by Andrew Lo <[email protected]> on 2012-11-23
Reviewed by Yong Li.
Internally reviewed by Mike Fenton.
Internal PR249523
Incorrectly used y coordinate as x coordinate in
InputHandler::ensureFocusTextElementVisible.
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
Modified Paths
Diff
Modified: trunk/Source/WebKit/blackberry/ChangeLog (135593 => 135594)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-11-23 12:48:34 UTC (rev 135593)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-11-23 12:54:53 UTC (rev 135594)
@@ -1,3 +1,18 @@
+2012-11-23 Andrew Lo <[email protected]>
+
+ [BlackBerry] InputHandler::ensureFocusTextElementVisible incorrectly used y coordinate as x coordinate
+ https://bugs.webkit.org/show_bug.cgi?id=103091
+
+ Reviewed by Yong Li.
+
+ Internally reviewed by Mike Fenton.
+ Internal PR249523
+ Incorrectly used y coordinate as x coordinate in
+ InputHandler::ensureFocusTextElementVisible.
+
+ * WebKitSupport/InputHandler.cpp:
+ (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
+
2012-11-22 Jeff Rogers <[email protected]>
[BlackBerry] Update Web Notifications Implementation
Modified: trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp (135593 => 135594)
--- trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp 2012-11-23 12:48:34 UTC (rev 135593)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp 2012-11-23 12:54:53 UTC (rev 135594)
@@ -1133,7 +1133,7 @@
zoomScaleRequired = m_webPage->currentScale(); // Don't scale.
// The scroll location we should go to given the zoom required, could be adjusted later.
- WebCore::FloatPoint offset(selectionFocusRect.location().y() - m_webPage->scrollPosition().x(), selectionFocusRect.location().y() - m_webPage->scrollPosition().y());
+ WebCore::FloatPoint offset(selectionFocusRect.location().x() - m_webPage->scrollPosition().x(), selectionFocusRect.location().y() - m_webPage->scrollPosition().y());
double inverseScale = zoomScaleRequired / m_webPage->currentScale();
WebCore::IntPoint destinationScrollLocation = WebCore::IntPoint(max(0, static_cast<int>(roundf(selectionFocusRect.location().x() - offset.x() / inverseScale))),
max(0, static_cast<int>(roundf(selectionFocusRect.location().y() - offset.y() / inverseScale))));
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
