Title: [135639] trunk/Source/WebKit/blackberry
- Revision
- 135639
- Author
- [email protected]
- Date
- 2012-11-23 17:30:21 -0800 (Fri, 23 Nov 2012)
Log Message
[BlackBerry] Define platform limitations in platform layer
https://bugs.webkit.org/show_bug.cgi?id=103160
Patch by Nima Ghanavatian <[email protected]> on 2012-11-23
Reviewed by Rob Buis.
Taking length as const unsigned in checkSpellingOfStringAsync.
This value is unchanging and should never be less than 0, even
in an error case.
Internally reviewed by Mike Fenton.
* Api/WebPageClient.h:
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::requestCheckingOfString):
Modified Paths
Diff
Modified: trunk/Source/WebKit/blackberry/Api/WebPageClient.h (135638 => 135639)
--- trunk/Source/WebKit/blackberry/Api/WebPageClient.h 2012-11-24 00:42:39 UTC (rev 135638)
+++ trunk/Source/WebKit/blackberry/Api/WebPageClient.h 2012-11-24 01:30:21 UTC (rev 135639)
@@ -151,7 +151,7 @@
virtual void showVirtualKeyboard(bool) = 0;
virtual void requestSpellingCheckingOptions(imf_sp_text_t&, const BlackBerry::Platform::IntRect& documentCaretRect, const BlackBerry::Platform::IntSize& screenOffset) = 0;
- virtual int32_t checkSpellingOfStringAsync(wchar_t* text, int length) = 0;
+ virtual int32_t checkSpellingOfStringAsync(wchar_t* text, const unsigned length) = 0;
virtual void notifySelectionDetailsChanged(const Platform::IntRect& documentStartRect, const Platform::IntRect& documentEndRect, const Platform::IntRectRegion& documentRegion, bool overrideTouchHandling = false) = 0;
virtual void cancelSelectionVisuals() = 0;
Modified: trunk/Source/WebKit/blackberry/ChangeLog (135638 => 135639)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-11-24 00:42:39 UTC (rev 135638)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-11-24 01:30:21 UTC (rev 135639)
@@ -1,3 +1,20 @@
+2012-11-23 Nima Ghanavatian <[email protected]>
+
+ [BlackBerry] Define platform limitations in platform layer
+ https://bugs.webkit.org/show_bug.cgi?id=103160
+
+ Reviewed by Rob Buis.
+
+ Taking length as const unsigned in checkSpellingOfStringAsync.
+ This value is unchanging and should never be less than 0, even
+ in an error case.
+
+ Internally reviewed by Mike Fenton.
+
+ * Api/WebPageClient.h:
+ * WebKitSupport/InputHandler.cpp:
+ (BlackBerry::WebKit::InputHandler::requestCheckingOfString):
+
2012-11-23 Jacky Jiang <[email protected]>
[BlackBerry] Meta viewport can't be changed dynamically
Modified: trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp (135638 => 135639)
--- trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp 2012-11-24 00:42:39 UTC (rev 135638)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp 2012-11-24 01:30:21 UTC (rev 135639)
@@ -64,6 +64,7 @@
#include "htmlediting.h"
#include "visible_units.h"
+#include <BlackBerryPlatformIMF.h>
#include <BlackBerryPlatformKeyboardEvent.h>
#include <BlackBerryPlatformLog.h>
#include <BlackBerryPlatformMisc.h>
@@ -77,7 +78,6 @@
#define ENABLE_SPELLING_LOG 0
static const unsigned MaxLearnTextDataSize = 500;
-static const unsigned MaxSpellCheckingStringLength = 250;
using namespace BlackBerry::Platform;
using namespace WebCore;
@@ -616,7 +616,7 @@
return;
}
- m_processingTransactionId = m_webPage->m_client->checkSpellingOfStringAsync(checkingString, paragraphLength);
+ m_processingTransactionId = m_webPage->m_client->checkSpellingOfStringAsync(checkingString, static_cast<unsigned>(paragraphLength));
free(checkingString);
// If the call to the input service did not go through, then cancel the request so we don't block endlessly.
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
