Title: [135643] trunk/Source/WebCore
Revision
135643
Author
[email protected]
Date
2012-11-23 22:40:29 -0800 (Fri, 23 Nov 2012)

Log Message

Fix unused parameter compile warnings
https://bugs.webkit.org/show_bug.cgi?id=103167

Patch by Kangil Han <[email protected]> on 2012-11-23
Reviewed by Gyuyoung Kim.

Remove compile warning messages by omitting parameter name and using UNUSED_PARAM.

* accessibility/atk/WebKitAccessibleHyperlink.cpp:
(webkitAccessibleHyperlinkIsSelectedLink):
* accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(webkitAccessibleTextGetTextAfterOffset):
(webkitAccessibleTextGetTextAtOffset):
(webkitAccessibleTextGetTextBeforeOffset):
(webkitAccessibleTextGetOffsetAtPoint):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (135642 => 135643)


--- trunk/Source/WebCore/ChangeLog	2012-11-24 06:13:20 UTC (rev 135642)
+++ trunk/Source/WebCore/ChangeLog	2012-11-24 06:40:29 UTC (rev 135643)
@@ -1,3 +1,20 @@
+2012-11-23  Kangil Han  <[email protected]>
+
+        Fix unused parameter compile warnings
+        https://bugs.webkit.org/show_bug.cgi?id=103167
+
+        Reviewed by Gyuyoung Kim.
+
+        Remove compile warning messages by omitting parameter name and using UNUSED_PARAM.
+
+        * accessibility/atk/WebKitAccessibleHyperlink.cpp:
+        (webkitAccessibleHyperlinkIsSelectedLink):
+        * accessibility/atk/WebKitAccessibleInterfaceText.cpp:
+        (webkitAccessibleTextGetTextAfterOffset):
+        (webkitAccessibleTextGetTextAtOffset):
+        (webkitAccessibleTextGetTextBeforeOffset):
+        (webkitAccessibleTextGetOffsetAtPoint):
+
 2012-11-23  Michael Saboff  <[email protected]>
 
         listMarkerText() should create 8 bit strings when possible

Modified: trunk/Source/WebCore/accessibility/atk/WebKitAccessibleHyperlink.cpp (135642 => 135643)


--- trunk/Source/WebCore/accessibility/atk/WebKitAccessibleHyperlink.cpp	2012-11-24 06:13:20 UTC (rev 135642)
+++ trunk/Source/WebCore/accessibility/atk/WebKitAccessibleHyperlink.cpp	2012-11-24 06:40:29 UTC (rev 135643)
@@ -281,7 +281,7 @@
     return 1;
 }
 
-static gboolean webkitAccessibleHyperlinkIsSelectedLink(AtkHyperlink* link)
+static gboolean webkitAccessibleHyperlinkIsSelectedLink(AtkHyperlink*)
 {
     // Not implemented: this function is deprecated in ATK now
     notImplemented();

Modified: trunk/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp (135642 => 135643)


--- trunk/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp	2012-11-24 06:13:20 UTC (rev 135642)
+++ trunk/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp	2012-11-24 06:40:29 UTC (rev 135643)
@@ -567,6 +567,12 @@
 #if PLATFORM(GTK)
     return gail_text_util_get_text(getGailTextUtilForAtk(text), getPangoLayoutForAtk(text), GAIL_AFTER_OFFSET, boundaryType, offset, startOffset, endOffset);
 #else
+    UNUSED_PARAM(text);
+    UNUSED_PARAM(offset);
+    UNUSED_PARAM(boundaryType);
+    UNUSED_PARAM(startOffset);
+    UNUSED_PARAM(endOffset);
+
     notImplemented();
     return 0;
 #endif
@@ -577,6 +583,12 @@
 #if PLATFORM(GTK)
     return gail_text_util_get_text(getGailTextUtilForAtk(text), getPangoLayoutForAtk(text), GAIL_AT_OFFSET, boundaryType, offset, startOffset, endOffset);
 #else
+    UNUSED_PARAM(text);
+    UNUSED_PARAM(offset);
+    UNUSED_PARAM(boundaryType);
+    UNUSED_PARAM(startOffset);
+    UNUSED_PARAM(endOffset);
+
     notImplemented();
     return 0;
 #endif
@@ -587,6 +599,12 @@
 #if PLATFORM(GTK)
     return gail_text_util_get_text(getGailTextUtilForAtk(text), getPangoLayoutForAtk(text), GAIL_BEFORE_OFFSET, boundaryType, offset, startOffset, endOffset);
 #else
+    UNUSED_PARAM(text);
+    UNUSED_PARAM(offset);
+    UNUSED_PARAM(boundaryType);
+    UNUSED_PARAM(startOffset);
+    UNUSED_PARAM(endOffset);
+
     notImplemented();
     return 0;
 #endif
@@ -684,7 +702,7 @@
     return accessibilityObjectLength(core(text));
 }
 
-static gint webkitAccessibleTextGetOffsetAtPoint(AtkText* text, gint x, gint y, AtkCoordType coords)
+static gint webkitAccessibleTextGetOffsetAtPoint(AtkText* text, gint x, gint y, AtkCoordType)
 {
     // FIXME: Use the AtkCoordType
     // TODO: Is it correct to ignore range.length?
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to