Title: [135655] trunk/Source/WebKit/blackberry
- Revision
- 135655
- Author
- [email protected]
- Date
- 2012-11-24 11:35:56 -0800 (Sat, 24 Nov 2012)
Log Message
[BlackBerry] Text not selected when input field focused.
https://bugs.webkit.org/show_bug.cgi?id=103182
Patch by Genevieve Mak <[email protected]> on 2012-11-24
Reviewed by George Staikos.
Reviewed Internally by: Mike Fenton, Eli Fidler
PR #250163
* WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::selectObject):
Modified Paths
Diff
Modified: trunk/Source/WebKit/blackberry/ChangeLog (135654 => 135655)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-11-24 19:24:12 UTC (rev 135654)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-11-24 19:35:56 UTC (rev 135655)
@@ -1,3 +1,16 @@
+2012-11-24 Genevieve Mak <[email protected]>
+
+ [BlackBerry] Text not selected when input field focused.
+ https://bugs.webkit.org/show_bug.cgi?id=103182
+
+ Reviewed by George Staikos.
+
+ Reviewed Internally by: Mike Fenton, Eli Fidler
+ PR #250163
+
+ * WebKitSupport/SelectionHandler.cpp:
+ (BlackBerry::WebKit::SelectionHandler::selectObject):
+
2012-11-23 Nima Ghanavatian <[email protected]>
[BlackBerry] Define platform limitations in platform layer
Modified: trunk/Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp (135654 => 135655)
--- trunk/Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp 2012-11-24 19:24:12 UTC (rev 135654)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp 2012-11-24 19:35:56 UTC (rev 135655)
@@ -664,6 +664,10 @@
if (!node)
return;
+ // Clear input focus if we're not selecting text there.
+ if (node != m_webPage->m_inputHandler->currentFocusElement().get())
+ m_webPage->clearFocusNode();
+
m_selectionActive = true;
ASSERT(m_webPage && m_webPage->focusedOrMainFrame() && m_webPage->focusedOrMainFrame()->selection());
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
