Title: [135657] trunk/Source/WebCore
- Revision
- 135657
- Author
- [email protected]
- Date
- 2012-11-24 12:34:40 -0800 (Sat, 24 Nov 2012)
Log Message
[BlackBerry] RTSP should use the same MediaDocument as HTTP videos.
https://bugs.webkit.org/show_bug.cgi?id=103185
RIM PR 250114
Patch by Liam Quinn <[email protected]> on 2012-11-24
Reviewed by George Staikos.
Make our MediaPlayer implementation indicate that it supports RTSP. That way, DOMImplementation::createDocument will create the same MediaDocument as is used for HTTP videos.
* platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore::MediaPlayerPrivate::supportsType):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (135656 => 135657)
--- trunk/Source/WebCore/ChangeLog 2012-11-24 20:31:27 UTC (rev 135656)
+++ trunk/Source/WebCore/ChangeLog 2012-11-24 20:34:40 UTC (rev 135657)
@@ -1,3 +1,16 @@
+2012-11-24 Liam Quinn <[email protected]>
+
+ [BlackBerry] RTSP should use the same MediaDocument as HTTP videos.
+ https://bugs.webkit.org/show_bug.cgi?id=103185
+ RIM PR 250114
+
+ Reviewed by George Staikos.
+
+ Make our MediaPlayer implementation indicate that it supports RTSP. That way, DOMImplementation::createDocument will create the same MediaDocument as is used for HTTP videos.
+
+ * platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
+ (WebCore::MediaPlayerPrivate::supportsType):
+
2012-11-24 Andreas Kling <[email protected]>
Put computed style 'font-family' values in the CSSValuePool.
Modified: trunk/Source/WebCore/platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp (135656 => 135657)
--- trunk/Source/WebCore/platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp 2012-11-24 20:31:27 UTC (rev 135656)
+++ trunk/Source/WebCore/platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp 2012-11-24 20:34:40 UTC (rev 135657)
@@ -76,19 +76,21 @@
types.add(*i);
}
-MediaPlayer::SupportsType MediaPlayerPrivate::supportsType(const WTF::String& type, const WTF::String& codecs, const KURL&)
+MediaPlayer::SupportsType MediaPlayerPrivate::supportsType(const WTF::String& type, const WTF::String& codecs, const KURL& url)
{
- if (type.isNull() || type.isEmpty()) {
+ bool isRTSP = url.protocolIs("rtsp");
+
+ if (!isRTSP && (type.isNull() || type.isEmpty())) {
LOG(Media, "MediaPlayer does not support type; type is null or empty.");
return MediaPlayer::IsNotSupported;
}
// spec says we should not return "probably" if the codecs string is empty
- if (PlatformPlayer::mimeTypeSupported(type.ascii().data())) {
- LOG(Media, "MediaPlayer supports type; cache contains type '%s'.", type.ascii().data());
+ if (isRTSP || PlatformPlayer::mimeTypeSupported(type.ascii().data())) {
+ LOG(Media, "MediaPlayer supports type %s.", isRTSP ? "rtsp" : type.ascii().data());
return codecs.isEmpty() ? MediaPlayer::MayBeSupported : MediaPlayer::IsSupported;
}
- LOG(Media, "MediaPlayer does not support type; cache doesn't contain type '%s'.", type.ascii().data());
+ LOG(Media, "MediaPlayer does not support type %s.", type.ascii().data());
return MediaPlayer::IsNotSupported;
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
