Title: [135679] trunk/Source/WebCore
- Revision
- 135679
- Author
- [email protected]
- Date
- 2012-11-25 21:58:39 -0800 (Sun, 25 Nov 2012)
Log Message
Web Inspector: dispatch an event upon heap snapshot filter change
https://bugs.webkit.org/show_bug.cgi?id=103201
Patch by Nikita Vasilyev <[email protected]> on 2012-11-25
Reviewed by Pavel Feldman.
Dispatch heapSnapshotFilterChanged event so it can be received by third parties.
* inspector/front-end/HeapSnapshotView.js:
(WebInspector.HeapSnapshotView.prototype._changeFilter):
* inspector/front-end/UserMetrics.js:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (135678 => 135679)
--- trunk/Source/WebCore/ChangeLog 2012-11-26 05:12:29 UTC (rev 135678)
+++ trunk/Source/WebCore/ChangeLog 2012-11-26 05:58:39 UTC (rev 135679)
@@ -1,3 +1,16 @@
+2012-11-25 Nikita Vasilyev <[email protected]>
+
+ Web Inspector: dispatch an event upon heap snapshot filter change
+ https://bugs.webkit.org/show_bug.cgi?id=103201
+
+ Reviewed by Pavel Feldman.
+
+ Dispatch heapSnapshotFilterChanged event so it can be received by third parties.
+
+ * inspector/front-end/HeapSnapshotView.js:
+ (WebInspector.HeapSnapshotView.prototype._changeFilter):
+ * inspector/front-end/UserMetrics.js:
+
2012-11-25 Kent Tamura <[email protected]>
Refactoring: Move the content of HTMLInputElement::subtreeHasChanged to TextFieldInputType
Modified: trunk/Source/WebCore/inspector/front-end/HeapSnapshotView.js (135678 => 135679)
--- trunk/Source/WebCore/inspector/front-end/HeapSnapshotView.js 2012-11-26 05:12:29 UTC (rev 135678)
+++ trunk/Source/WebCore/inspector/front-end/HeapSnapshotView.js 2012-11-26 05:58:39 UTC (rev 135679)
@@ -388,6 +388,11 @@
var profileIndex = this.filterSelectElement.selectedIndex - 1;
this.dataGrid.filterSelectIndexChanged(this._profiles(), profileIndex);
+ WebInspector.notifications.dispatchEventToListeners(WebInspector.UserMetrics.UserAction, {
+ action: WebInspector.UserMetrics.UserActionNames.HeapSnapshotFilterChanged,
+ label: this.filterSelectElement[this.filterSelectElement.selectedIndex].label
+ });
+
if (!this.currentQuery || !this._searchFinishedCallback || !this._searchResults)
return;
Modified: trunk/Source/WebCore/inspector/front-end/UserMetrics.js (135678 => 135679)
--- trunk/Source/WebCore/inspector/front-end/UserMetrics.js 2012-11-26 05:12:29 UTC (rev 135678)
+++ trunk/Source/WebCore/inspector/front-end/UserMetrics.js 2012-11-26 05:58:39 UTC (rev 135679)
@@ -102,7 +102,7 @@
NetworkSort: "networkSort",
NetworkRequestSelected: "networkRequestSelected",
NetworkRequestTabSelected: "networkRequestTabSelected",
- ChoseHeapSnapshotBetween: "choseHeapSnapshotBetween"
+ HeapSnapshotFilterChanged: "heapSnapshotFilterChanged"
};
WebInspector.UserMetrics.prototype = {
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
