Title: [135801] trunk/Source
Revision
135801
Author
[email protected]
Date
2012-11-26 18:25:46 -0800 (Mon, 26 Nov 2012)

Log Message

[chromium] Remove deprecated and unused WebGraphicsContext3D compositor binding calls
https://bugs.webkit.org/show_bug.cgi?id=103322

Patch by James Robinson <[email protected]> on 2012-11-26
Reviewed by Adam Barth.

Source/Platform:

These have been uncalled for a while.

* chromium/public/WebLayerTreeViewClient.h:
(WebLayerTreeViewClient):

Source/WebKit/chromium:

* src/WebViewImpl.cpp:
* src/WebViewImpl.h:
(WebViewImpl):

Modified Paths

Diff

Modified: trunk/Source/Platform/ChangeLog (135800 => 135801)


--- trunk/Source/Platform/ChangeLog	2012-11-27 02:22:53 UTC (rev 135800)
+++ trunk/Source/Platform/ChangeLog	2012-11-27 02:25:46 UTC (rev 135801)
@@ -1,3 +1,15 @@
+2012-11-26  James Robinson  <[email protected]>
+
+        [chromium] Remove deprecated and unused WebGraphicsContext3D compositor binding calls
+        https://bugs.webkit.org/show_bug.cgi?id=103322
+
+        Reviewed by Adam Barth.
+
+        These have been uncalled for a while.
+
+        * chromium/public/WebLayerTreeViewClient.h:
+        (WebLayerTreeViewClient):
+
 2012-11-23  Sami Kyostila  <[email protected]>
 
         [chromium] Remove WebScreenInfo.{horizontal,vertical}DPI

Modified: trunk/Source/Platform/chromium/public/WebLayerTreeViewClient.h (135800 => 135801)


--- trunk/Source/Platform/chromium/public/WebLayerTreeViewClient.h	2012-11-27 02:22:53 UTC (rev 135800)
+++ trunk/Source/Platform/chromium/public/WebLayerTreeViewClient.h	2012-11-27 02:25:46 UTC (rev 135801)
@@ -28,7 +28,6 @@
 
 namespace WebKit {
 class WebCompositorOutputSurface;
-class WebGraphicsContext3D;
 class WebInputHandler;
 class WebThread;
 struct WebSize;
@@ -57,15 +56,6 @@
     // compositor thread through the WebCompositor interface.
     virtual void applyScrollAndScale(const WebSize& scrollDelta, float scaleFactor) = 0;
 
-    // DEPRECATED: Creates a 3D context suitable for the compositing. This may be called
-    // more than once if the context gets lost. This will be removed once
-    // downstream dependencies have been removed.
-    virtual WebGraphicsContext3D* createContext3D() { return 0; }
-
-    // DEPRECATED: Signals a successful rebinding of the 3D context (e.g. after a lost
-    // context event).
-    virtual void didRebindGraphicsContext(bool) { return; }
-
     // Creates the output surface. This may be called more than once
     // if the context gets lost.
     virtual WebCompositorOutputSurface* createOutputSurface() { return 0; }

Modified: trunk/Source/WebKit/chromium/ChangeLog (135800 => 135801)


--- trunk/Source/WebKit/chromium/ChangeLog	2012-11-27 02:22:53 UTC (rev 135800)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-11-27 02:25:46 UTC (rev 135801)
@@ -1,3 +1,14 @@
+2012-11-26  James Robinson  <[email protected]>
+
+        [chromium] Remove deprecated and unused WebGraphicsContext3D compositor binding calls
+        https://bugs.webkit.org/show_bug.cgi?id=103322
+
+        Reviewed by Adam Barth.
+
+        * src/WebViewImpl.cpp:
+        * src/WebViewImpl.h:
+        (WebViewImpl):
+
 2012-11-26  Alpha Lam  <[email protected]>
 
         [chromium] Implement full-featured image cache

Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.cpp (135800 => 135801)


--- trunk/Source/WebKit/chromium/src/WebViewImpl.cpp	2012-11-27 02:22:53 UTC (rev 135800)
+++ trunk/Source/WebKit/chromium/src/WebViewImpl.cpp	2012-11-27 02:25:46 UTC (rev 135801)
@@ -4110,17 +4110,6 @@
 
 } // namespace
 
-WebGraphicsContext3D* WebViewImpl::createContext3D()
-{
-    // Temporarily, if the output surface can't be created, create a WebGraphicsContext3D
-    // directly. This allows bootstrapping the output surface system while downstream
-    // users of the API still use the old approach.
-    WebKit::WebGraphicsContext3D::Attributes attributes;
-    attributes.antialias = false;
-    attributes.shareResources = true;
-    return m_client->createGraphicsContext3D(attributes);
-}
-
 WebCompositorOutputSurface* WebViewImpl::createOutputSurface()
 {
     return m_client->createOutputSurface();
@@ -4185,11 +4174,6 @@
         m_client->didCompleteSwapBuffers();
 }
 
-void WebViewImpl::didRebindGraphicsContext(bool success)
-{
-    didRecreateOutputSurface(success);
-}
-
 void WebViewImpl::didRecreateOutputSurface(bool success)
 {
     // Switch back to software rendering mode, if necessary

Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.h (135800 => 135801)


--- trunk/Source/WebKit/chromium/src/WebViewImpl.h	2012-11-27 02:22:53 UTC (rev 135800)
+++ trunk/Source/WebKit/chromium/src/WebViewImpl.h	2012-11-27 02:25:46 UTC (rev 135801)
@@ -316,8 +316,6 @@
     virtual void didBeginFrame();
     virtual void updateAnimations(double monotonicFrameBeginTime);
     virtual void applyScrollAndScale(const WebSize&, float);
-    virtual WebGraphicsContext3D* createContext3D() OVERRIDE;
-    virtual void didRebindGraphicsContext(bool success) OVERRIDE;
     virtual WebCompositorOutputSurface* createOutputSurface() OVERRIDE;
     virtual void didRecreateOutputSurface(bool success) OVERRIDE;
     virtual WebInputHandler* createInputHandler() OVERRIDE;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to