Modified: trunk/Source/WebCore/ChangeLog (135907 => 135908)
--- trunk/Source/WebCore/ChangeLog 2012-11-27 21:05:32 UTC (rev 135907)
+++ trunk/Source/WebCore/ChangeLog 2012-11-27 21:05:40 UTC (rev 135908)
@@ -1,3 +1,18 @@
+2012-11-27 Mike West <[email protected]>
+
+ Expanding variable names in ConsoleMessage.
+ https://bugs.webkit.org/show_bug.cgi?id=103436
+
+ Reviewed by Adam Barth.
+
+ Variable names like 'm' should be replaced with full words, like
+ 'myOhMyThisIsAnAwesomeVariable' (or something more descriptive).
+
+ * inspector/ConsoleMessage.cpp:
+ (WebCore::ConsoleMessage::ConsoleMessage):
+ * inspector/ConsoleMessage.h:
+ (ConsoleMessage):
+
2012-11-27 Aaron Colwell <[email protected]>
Use-after-free in media player handling
Modified: trunk/Source/WebCore/inspector/ConsoleMessage.cpp (135907 => 135908)
--- trunk/Source/WebCore/inspector/ConsoleMessage.cpp 2012-11-27 21:05:32 UTC (rev 135907)
+++ trunk/Source/WebCore/inspector/ConsoleMessage.cpp 2012-11-27 21:05:40 UTC (rev 135908)
@@ -47,25 +47,24 @@
namespace WebCore {
-ConsoleMessage::ConsoleMessage(MessageSource s, MessageType t, MessageLevel l, const String& m, const String& u, unsigned li, unsigned long requestIdentifier)
- : m_source(s)
- , m_type(t)
- , m_level(l)
- , m_message(m)
- , m_url(u)
- , m_line(li)
+ConsoleMessage::ConsoleMessage(MessageSource source, MessageType type, MessageLevel level, const String& message, const String& url, unsigned line, unsigned long requestIdentifier)
+ : m_source(source)
+ , m_type(type)
+ , m_level(level)
+ , m_message(message)
+ , m_url(url)
+ , m_line(line)
, m_repeatCount(1)
, m_requestId(IdentifiersFactory::requestId(requestIdentifier))
{
}
-ConsoleMessage::ConsoleMessage(MessageSource s, MessageType t, MessageLevel l, const String& m, PassRefPtr<ScriptArguments> arguments, PassRefPtr<ScriptCallStack> callStack, unsigned long requestIdentifier)
- : m_source(s)
- , m_type(t)
- , m_level(l)
- , m_message(m)
+ConsoleMessage::ConsoleMessage(MessageSource source, MessageType type, MessageLevel level, const String& message, PassRefPtr<ScriptArguments> arguments, PassRefPtr<ScriptCallStack> callStack, unsigned long requestIdentifier)
+ : m_source(source)
+ , m_type(type)
+ , m_level(level)
+ , m_message(message)
, m_arguments(arguments)
- , m_url()
, m_line(0)
, m_repeatCount(1)
, m_requestId(IdentifiersFactory::requestId(requestIdentifier))
Modified: trunk/Source/WebCore/inspector/ConsoleMessage.h (135907 => 135908)
--- trunk/Source/WebCore/inspector/ConsoleMessage.h 2012-11-27 21:05:32 UTC (rev 135907)
+++ trunk/Source/WebCore/inspector/ConsoleMessage.h 2012-11-27 21:05:40 UTC (rev 135908)
@@ -51,8 +51,8 @@
class ConsoleMessage {
WTF_MAKE_NONCOPYABLE(ConsoleMessage); WTF_MAKE_FAST_ALLOCATED;
public:
- ConsoleMessage(MessageSource, MessageType, MessageLevel, const String& m, const String& u, unsigned li, unsigned long requestIdentifier = 0);
- ConsoleMessage(MessageSource, MessageType, MessageLevel, const String& m, PassRefPtr<ScriptArguments>, PassRefPtr<ScriptCallStack>, unsigned long requestIdentifier = 0);
+ ConsoleMessage(MessageSource, MessageType, MessageLevel, const String& message, const String& url, unsigned line, unsigned long requestIdentifier = 0);
+ ConsoleMessage(MessageSource, MessageType, MessageLevel, const String& message, PassRefPtr<ScriptArguments>, PassRefPtr<ScriptCallStack>, unsigned long requestIdentifier = 0);
~ConsoleMessage();
void addToFrontend(InspectorFrontend::Console*, InjectedScriptManager*, bool generatePreview);
