Title: [136132] trunk
- Revision
- 136132
- Author
- [email protected]
- Date
- 2012-11-29 07:34:39 -0800 (Thu, 29 Nov 2012)
Log Message
Typo in 'autofocus' sandboxing error message.
https://bugs.webkit.org/show_bug.cgi?id=103616
Reviewed by Jochen Eisinger.
Source/WebCore:
The sandbox attribute name is 'allow-scripts', not 'allow-script'. :(
* html/HTMLFormControlElement.cpp:
(WebCore::shouldAutofocus):
LayoutTests:
* fast/frames/sandboxed-iframe-autofocus-denied-expected.txt:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (136131 => 136132)
--- trunk/LayoutTests/ChangeLog 2012-11-29 15:33:03 UTC (rev 136131)
+++ trunk/LayoutTests/ChangeLog 2012-11-29 15:34:39 UTC (rev 136132)
@@ -1,3 +1,12 @@
+2012-11-29 Mike West <[email protected]>
+
+ Typo in 'autofocus' sandboxing error message.
+ https://bugs.webkit.org/show_bug.cgi?id=103616
+
+ Reviewed by Jochen Eisinger.
+
+ * fast/frames/sandboxed-iframe-autofocus-denied-expected.txt:
+
2012-11-29 Hajime Morrita <[email protected]>
HTMLMediaElement's .textTracks property does not reflect <track> element
Modified: trunk/LayoutTests/fast/frames/sandboxed-iframe-autofocus-denied-expected.txt (136131 => 136132)
--- trunk/LayoutTests/fast/frames/sandboxed-iframe-autofocus-denied-expected.txt 2012-11-29 15:33:03 UTC (rev 136131)
+++ trunk/LayoutTests/fast/frames/sandboxed-iframe-autofocus-denied-expected.txt 2012-11-29 15:34:39 UTC (rev 136132)
@@ -1,4 +1,4 @@
-CONSOLE MESSAGE: Blocked autofocusing on a form control because the form's frame is sandboxed and the 'allow-script' permission is not set.
+CONSOLE MESSAGE: Blocked autofocusing on a form control because the form's frame is sandboxed and the 'allow-scripts' permission is not set.
CONSOLE MESSAGE: line 13: PASS: The input element is not focused.
This test passes if the input element in the sandboxed frame is not automatically focused upon, as it should be blocked by the sandboxed scripts flag. A console warning to that effect should also be present.
Modified: trunk/Source/WebCore/ChangeLog (136131 => 136132)
--- trunk/Source/WebCore/ChangeLog 2012-11-29 15:33:03 UTC (rev 136131)
+++ trunk/Source/WebCore/ChangeLog 2012-11-29 15:34:39 UTC (rev 136132)
@@ -1,3 +1,15 @@
+2012-11-29 Mike West <[email protected]>
+
+ Typo in 'autofocus' sandboxing error message.
+ https://bugs.webkit.org/show_bug.cgi?id=103616
+
+ Reviewed by Jochen Eisinger.
+
+ The sandbox attribute name is 'allow-scripts', not 'allow-script'. :(
+
+ * html/HTMLFormControlElement.cpp:
+ (WebCore::shouldAutofocus):
+
2012-11-29 Hajime Morrita <[email protected]>
HTMLMediaElement's .textTracks property does not reflect <track> element
Modified: trunk/Source/WebCore/html/HTMLFormControlElement.cpp (136131 => 136132)
--- trunk/Source/WebCore/html/HTMLFormControlElement.cpp 2012-11-29 15:33:03 UTC (rev 136131)
+++ trunk/Source/WebCore/html/HTMLFormControlElement.cpp 2012-11-29 15:34:39 UTC (rev 136132)
@@ -174,7 +174,7 @@
return false;
if (element->document()->isSandboxed(SandboxAutomaticFeatures)) {
// FIXME: This message should be moved off the console once a solution to https://bugs.webkit.org/show_bug.cgi?id=103274 exists.
- element->document()->addConsoleMessage(HTMLMessageSource, LogMessageType, ErrorMessageLevel, "Blocked autofocusing on a form control because the form's frame is sandboxed and the 'allow-script' permission is not set.");
+ element->document()->addConsoleMessage(HTMLMessageSource, LogMessageType, ErrorMessageLevel, "Blocked autofocusing on a form control because the form's frame is sandboxed and the 'allow-scripts' permission is not set.");
return false;
}
if (element->hasAutofocused())
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
