Title: [136172] trunk/Source/WebKit2
- Revision
- 136172
- Author
- [email protected]
- Date
- 2012-11-29 15:16:13 -0800 (Thu, 29 Nov 2012)
Log Message
CoreIPC::Connection should retain its xpc_connection_t
https://bugs.webkit.org/show_bug.cgi?id=103671
<rdar://problem/12717331>
Reviewed by Beth Dakin.
* Platform/CoreIPC/mac/ConnectionMac.cpp:
(CoreIPC::Connection::platformInitialize):
Retain the xpc_connection_t object here to balance the xpc_object_release in platformInvalidate.
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (136171 => 136172)
--- trunk/Source/WebKit2/ChangeLog 2012-11-29 23:07:23 UTC (rev 136171)
+++ trunk/Source/WebKit2/ChangeLog 2012-11-29 23:16:13 UTC (rev 136172)
@@ -1,3 +1,15 @@
+2012-11-29 Anders Carlsson <[email protected]>
+
+ CoreIPC::Connection should retain its xpc_connection_t
+ https://bugs.webkit.org/show_bug.cgi?id=103671
+ <rdar://problem/12717331>
+
+ Reviewed by Beth Dakin.
+
+ * Platform/CoreIPC/mac/ConnectionMac.cpp:
+ (CoreIPC::Connection::platformInitialize):
+ Retain the xpc_connection_t object here to balance the xpc_object_release in platformInvalidate.
+
2012-11-29 Brent Fulgham <[email protected]>
[Windows, WinCairo] Unreviewed build fix. Build was failing
Modified: trunk/Source/WebKit2/Platform/CoreIPC/mac/ConnectionMac.cpp (136171 => 136172)
--- trunk/Source/WebKit2/Platform/CoreIPC/mac/ConnectionMac.cpp 2012-11-29 23:07:23 UTC (rev 136171)
+++ trunk/Source/WebKit2/Platform/CoreIPC/mac/ConnectionMac.cpp 2012-11-29 23:16:13 UTC (rev 136172)
@@ -92,7 +92,10 @@
}
#if HAVE(XPC)
- m_xpcConnection = identifier.xpcConnection;
+ // FIXME: Instead of explicitly retaining the connection here, Identifier::xpcConnection
+ // should just be a smart pointer.
+ if (identifier.xpcConnection)
+ m_xpcConnection = static_cast<xpc_connection_t>(xpc_retain(identifier.xpcConnection));
#endif
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
