Title: [136187] trunk/Source/WebCore
- Revision
- 136187
- Author
- [email protected]
- Date
- 2012-11-29 17:06:47 -0800 (Thu, 29 Nov 2012)
Log Message
Web Inspector: optimize repaint regions upon text editing
https://bugs.webkit.org/show_bug.cgi?id=103674
Reviewed by Vsevolod Vlasov.
There is a lot happening that makes repaint area larger than it should be,
namely unnecessary tabbed pane and navigator updates.
* inspector/front-end/NavigatorView.js:
(WebInspector.NavigatorView.prototype._updateScriptTitle):
* inspector/front-end/TabbedPane.js:
(WebInspector.TabbedPaneTab.prototype.set title):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (136186 => 136187)
--- trunk/Source/WebCore/ChangeLog 2012-11-30 01:02:12 UTC (rev 136186)
+++ trunk/Source/WebCore/ChangeLog 2012-11-30 01:06:47 UTC (rev 136187)
@@ -1,3 +1,18 @@
+2012-11-29 Pavel Feldman <[email protected]>
+
+ Web Inspector: optimize repaint regions upon text editing
+ https://bugs.webkit.org/show_bug.cgi?id=103674
+
+ Reviewed by Vsevolod Vlasov.
+
+ There is a lot happening that makes repaint area larger than it should be,
+ namely unnecessary tabbed pane and navigator updates.
+
+ * inspector/front-end/NavigatorView.js:
+ (WebInspector.NavigatorView.prototype._updateScriptTitle):
+ * inspector/front-end/TabbedPane.js:
+ (WebInspector.TabbedPaneTab.prototype.set title):
+
2012-11-29 KyungTae Kim <[email protected]>
Unused parameters on plugins/npapi.cpp
Modified: trunk/Source/WebCore/inspector/front-end/NavigatorView.js (136186 => 136187)
--- trunk/Source/WebCore/inspector/front-end/NavigatorView.js 2012-11-30 01:02:12 UTC (rev 136186)
+++ trunk/Source/WebCore/inspector/front-end/NavigatorView.js 2012-11-30 01:06:47 UTC (rev 136187)
@@ -479,6 +479,8 @@
set titleText(titleText)
{
+ if (this._titleText === titleText)
+ return;
this._titleText = titleText || "";
if (this.titleElement)
this.titleElement.textContent = this._titleText;
Modified: trunk/Source/WebCore/inspector/front-end/TabbedPane.js (136186 => 136187)
--- trunk/Source/WebCore/inspector/front-end/TabbedPane.js 2012-11-30 01:02:12 UTC (rev 136186)
+++ trunk/Source/WebCore/inspector/front-end/TabbedPane.js 2012-11-30 01:06:47 UTC (rev 136187)
@@ -598,6 +598,8 @@
set title(title)
{
+ if (title === this._title)
+ return;
this._title = title;
if (this._titleElement)
this._titleElement.textContent = title;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes