[webkit-changes] [136218] trunk/Source/JavaScriptCore

[commit-queue]

Title: [136218] trunk/Source/_javascript_Core

Revision

136218

Author

commit-qu...@webkit.org

Date

2012-11-30 02:19:32 -0800 (Fri, 30 Nov 2012)

Log Message

[sh4] Fix compilation warnings in _javascript_Core JIT for sh4 arch
https://bugs.webkit.org/show_bug.cgi?id=103378

Patch by Julien BRIANCEAU <jbrianc...@nds.com> on 2012-11-30
Reviewed by Filip Pizlo.

* assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::branchTest32):
(JSC::MacroAssemblerSH4::branchAdd32):
(JSC::MacroAssemblerSH4::branchMul32):
(JSC::MacroAssemblerSH4::branchSub32):
(JSC::MacroAssemblerSH4::branchOr32):

Modified Paths

• trunk/Source/_javascript_Core/ChangeLog
• trunk/Source/_javascript_Core/assembler/MacroAssemblerSH4.h

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (136217 => 136218)

--- trunk/Source/_javascript_Core/ChangeLog	2012-11-30 09:45:52 UTC (rev 136217)
+++ trunk/Source/_javascript_Core/ChangeLog	2012-11-30 10:19:32 UTC (rev 136218)
@@ -1,3 +1,17 @@
+2012-11-30  Julien BRIANCEAU   <jbrianc...@nds.com>
+
+        [sh4] Fix compilation warnings in _javascript_Core JIT for sh4 arch
+        https://bugs.webkit.org/show_bug.cgi?id=103378
+
+        Reviewed by Filip Pizlo.
+
+        * assembler/MacroAssemblerSH4.h:
+        (JSC::MacroAssemblerSH4::branchTest32):
+        (JSC::MacroAssemblerSH4::branchAdd32):
+        (JSC::MacroAssemblerSH4::branchMul32):
+        (JSC::MacroAssemblerSH4::branchSub32):
+        (JSC::MacroAssemblerSH4::branchOr32):
+
 2012-11-29  Rafael Weinstein  <rafa...@chromium.org>
 
         [HTMLTemplateElement] Add feature flag

Modified: trunk/Source/_javascript_Core/assembler/MacroAssemblerSH4.h (136217 => 136218)

--- trunk/Source/_javascript_Core/assembler/MacroAssemblerSH4.h	2012-11-30 09:45:52 UTC (rev 136217)
+++ trunk/Source/_javascript_Core/assembler/MacroAssemblerSH4.h	2012-11-30 10:19:32 UTC (rev 136218)
@@ -1793,7 +1793,7 @@
 
         m_assembler.testlRegReg(reg, mask);
 
-        if (cond == NotEqual)
+        if (cond == NonZero) // NotEqual
             return branchFalse();
         return branchTrue();
     }
@@ -1807,7 +1807,7 @@
         else
             testlImm(mask.m_value, reg);
 
-        if (cond == NotEqual)
+        if (cond == NonZero) // NotEqual
             return branchFalse();
         return branchTrue();
     }
@@ -1821,7 +1821,7 @@
         else
             testImm(mask.m_value, address.offset, address.base);
 
-        if (cond == NotEqual)
+        if (cond == NonZero) // NotEqual
             return branchFalse();
         return branchTrue();
     }
@@ -1842,7 +1842,7 @@
 
         releaseScratch(scr);
 
-        if (cond == NotEqual)
+        if (cond == NonZero) // NotEqual
             return branchFalse();
         return branchTrue();
     }
@@ -1895,7 +1895,7 @@
         m_assembler.addlRegReg(src, dest);
         compare32(0, dest, Equal);
 
-        if (cond == NotEqual)
+        if (cond == NonZero) // NotEqual
             return branchFalse();
         return branchTrue();
     }
@@ -1930,7 +1930,7 @@
 
         compare32(0, dest, Equal);
 
-        if (cond == NotEqual)
+        if (cond == NonZero) // NotEqual
             return branchFalse();
         return branchTrue();
     }
@@ -1964,7 +1964,7 @@
 
         compare32(0, dest, static_cast<RelationalCondition>(cond));
 
-        if (cond == NotEqual)
+        if (cond == NonZero) // NotEqual
             return branchFalse();
         return branchTrue();
     }
@@ -1999,7 +1999,7 @@
         sub32(src, dest);
         compare32(0, dest, static_cast<RelationalCondition>(cond));
 
-        if (cond == NotEqual)
+        if (cond == NonZero) // NotEqual
             return branchFalse();
         return branchTrue();
     }
@@ -2040,7 +2040,7 @@
         or32(src, dest);
         compare32(0, dest, static_cast<RelationalCondition>(cond));
 
-        if (cond == NotEqual)
+        if (cond == NonZero) // NotEqual
             return branchFalse();
         return branchTrue();
     }

_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes