Title: [136289] trunk/Source/WebCore
- Revision
- 136289
- Author
- timothy_hor...@apple.com
- Date
- 2012-11-30 15:30:33 -0800 (Fri, 30 Nov 2012)
Log Message
PluginDocument fires didFinishDocumentLoadForFrame upon receiving initial bytes instead of when load completes
https://bugs.webkit.org/show_bug.cgi?id=103702
<rdar://problem/12762534>
Reviewed by Alexey Proskuryakov.
Remove the call to finish() from PluginDocumentParser::appendBytes().
This was introduced in http://trac.webkit.org/changeset/14838, when finish() wouldn't get
called for PluginDocuments any other way. In the time since, DocumentWriter::end() was made
to call finish() anyway, at the correct time (the call from appendBytes makes a PluginDocument
appear to be finished loading after the first bytes are received).
No new tests, because there doesn't seem to be any state in a PluginDocument that can be accessed
from _javascript_ to determine whether or not it has finished loading.
* html/PluginDocument.cpp:
(WebCore::PluginDocumentParser::appendBytes):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (136288 => 136289)
--- trunk/Source/WebCore/ChangeLog 2012-11-30 23:21:59 UTC (rev 136288)
+++ trunk/Source/WebCore/ChangeLog 2012-11-30 23:30:33 UTC (rev 136289)
@@ -1,3 +1,24 @@
+2012-11-30 Tim Horton <timothy_hor...@apple.com>
+
+ PluginDocument fires didFinishDocumentLoadForFrame upon receiving initial bytes instead of when load completes
+ https://bugs.webkit.org/show_bug.cgi?id=103702
+ <rdar://problem/12762534>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Remove the call to finish() from PluginDocumentParser::appendBytes().
+
+ This was introduced in http://trac.webkit.org/changeset/14838, when finish() wouldn't get
+ called for PluginDocuments any other way. In the time since, DocumentWriter::end() was made
+ to call finish() anyway, at the correct time (the call from appendBytes makes a PluginDocument
+ appear to be finished loading after the first bytes are received).
+
+ No new tests, because there doesn't seem to be any state in a PluginDocument that can be accessed
+ from _javascript_ to determine whether or not it has finished loading.
+
+ * html/PluginDocument.cpp:
+ (WebCore::PluginDocumentParser::appendBytes):
+
2012-11-29 Ilya Tikhonovsky <loi...@chromium.org>
RenderBlock minor clean-up: replace raw pointers with OwnPtrs.
Modified: trunk/Source/WebCore/html/PluginDocument.cpp (136288 => 136289)
--- trunk/Source/WebCore/html/PluginDocument.cpp 2012-11-30 23:21:59 UTC (rev 136288)
+++ trunk/Source/WebCore/html/PluginDocument.cpp 2012-11-30 23:30:33 UTC (rev 136289)
@@ -133,8 +133,6 @@
frame->loader()->activeDocumentLoader()->mainResourceLoader()->setShouldBufferData(DoNotBufferData);
}
}
-
- finish();
}
PluginDocument::PluginDocument(Frame* frame, const KURL& url)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
