Title: [136313] trunk/Source/WebCore
- Revision
- 136313
- Author
- [email protected]
- Date
- 2012-12-01 16:31:21 -0800 (Sat, 01 Dec 2012)
Log Message
Unreviewed, rolling out r136015.
http://trac.webkit.org/changeset/136015
https://bugs.webkit.org/show_bug.cgi?id=103821
Did not heal performance bot and caused other performance
regressions (Requested by abarth on #webkit).
Patch by Sheriff Bot <[email protected]> on 2012-12-01
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (136312 => 136313)
--- trunk/Source/WebCore/ChangeLog 2012-12-01 21:33:11 UTC (rev 136312)
+++ trunk/Source/WebCore/ChangeLog 2012-12-02 00:31:21 UTC (rev 136313)
@@ -1,3 +1,15 @@
+2012-12-01 Sheriff Bot <[email protected]>
+
+ Unreviewed, rolling out r136015.
+ http://trac.webkit.org/changeset/136015
+ https://bugs.webkit.org/show_bug.cgi?id=103821
+
+ Did not heal performance bot and caused other performance
+ regressions (Requested by abarth on #webkit).
+
+ * bindings/scripts/CodeGeneratorV8.pm:
+ (GenerateHeader):
+
2012-12-01 Xiaobo Wang <[email protected]>
DRT - crashed in WebCore::SearchFieldCancelButtonElement::defaultEventHandler
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm (136312 => 136313)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2012-12-01 21:33:11 UTC (rev 136312)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2012-12-02 00:31:21 UTC (rev 136313)
@@ -593,11 +593,10 @@
// in an isolated world. The fastest way we know how to do that is to check
// whether the holder's inline wrapper is the same wrapper we see in the
// v8::AccessorInfo.
- v8::Handle<v8::Object> holderWrapper = info.Holder();
- v8::Handle<v8::Object> wrapper = (holder->wrapper() == holderWrapper) ? impl->wrapper() : DOMDataStore::getNode(impl, info.GetIsolate());
+ v8::Handle<v8::Object> wrapper = (holder->wrapper() == info.Holder()) ? impl->wrapper() : DOMDataStore::getNode(impl, info.GetIsolate());
if (!wrapper.IsEmpty())
return wrapper;
- return wrap(impl, holderWrapper, info.GetIsolate());
+ return wrap(impl, info.Holder(), info.GetIsolate());
}
END
}
Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestNode.h (136312 => 136313)
--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestNode.h 2012-12-01 21:33:11 UTC (rev 136312)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestNode.h 2012-12-02 00:31:21 UTC (rev 136313)
@@ -88,11 +88,10 @@
// in an isolated world. The fastest way we know how to do that is to check
// whether the holder's inline wrapper is the same wrapper we see in the
// v8::AccessorInfo.
- v8::Handle<v8::Object> holderWrapper = info.Holder();
- v8::Handle<v8::Object> wrapper = (holder->wrapper() == holderWrapper) ? impl->wrapper() : DOMDataStore::getNode(impl, info.GetIsolate());
+ v8::Handle<v8::Object> wrapper = (holder->wrapper() == info.Holder()) ? impl->wrapper() : DOMDataStore::getNode(impl, info.GetIsolate());
if (!wrapper.IsEmpty())
return wrapper;
- return wrap(impl, holderWrapper, info.GetIsolate());
+ return wrap(impl, info.Holder(), info.GetIsolate());
}
inline v8::Handle<v8::Value> toV8(PassRefPtr< TestNode > impl, v8::Handle<v8::Object> creationContext = v8::Handle<v8::Object>(), v8::Isolate* isolate = 0)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
