Title: [136317] trunk/Source/WebKit2
- Revision
- 136317
- Author
- [email protected]
- Date
- 2012-12-01 23:55:26 -0800 (Sat, 01 Dec 2012)
Log Message
PDFPlugin: Support PDF form editing in <iframe>s
https://bugs.webkit.org/show_bug.cgi?id=103287
<rdar://problem/10326917>
Reviewed by Dan Bernstein.
PDFPlugin form editing depends on having a Document that has the same
size and position as the plugin; this is true not only in the full-main-frame
case, but also in the <iframe> case. Therefore, we can enable form editing
for <iframe> PDFPlugins.
* WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::supportsForms): Support form editing whenever
our Document's widget is our PluginView (which will only be true in the
full-main-frame or <iframe> case).
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (136316 => 136317)
--- trunk/Source/WebKit2/ChangeLog 2012-12-02 07:51:36 UTC (rev 136316)
+++ trunk/Source/WebKit2/ChangeLog 2012-12-02 07:55:26 UTC (rev 136317)
@@ -1,5 +1,23 @@
2012-12-01 Tim Horton <[email protected]>
+ PDFPlugin: Support PDF form editing in <iframe>s
+ https://bugs.webkit.org/show_bug.cgi?id=103287
+ <rdar://problem/10326917>
+
+ Reviewed by Dan Bernstein.
+
+ PDFPlugin form editing depends on having a Document that has the same
+ size and position as the plugin; this is true not only in the full-main-frame
+ case, but also in the <iframe> case. Therefore, we can enable form editing
+ for <iframe> PDFPlugins.
+
+ * WebProcess/Plugins/PDF/PDFPlugin.mm:
+ (WebKit::PDFPlugin::supportsForms): Support form editing whenever
+ our Document's widget is our PluginView (which will only be true in the
+ full-main-frame or <iframe> case).
+
+2012-12-01 Tim Horton <[email protected]>
+
PDFPlugin: <embed> and <object> PDFs affect their parent frame's page scale
https://bugs.webkit.org/show_bug.cgi?id=103286
<rdar://problem/12752315>
Modified: trunk/Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm (136316 => 136317)
--- trunk/Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm 2012-12-02 07:51:36 UTC (rev 136316)
+++ trunk/Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm 2012-12-02 07:55:26 UTC (rev 136317)
@@ -751,8 +751,8 @@
bool PDFPlugin::supportsForms()
{
- // FIXME: Should we support forms for inline PDFs? Since we touch the document, this might be difficult.
- return webFrame()->isMainFrame() && isFullFramePlugin();
+ // FIXME: We support forms for full-main-frame and <iframe> PDFs, but not <embed> or <object>, because those cases do not have their own Document into which to inject form elements.
+ return isFullFramePlugin();
}
void PDFPlugin::notifyContentScaleFactorChanged(CGFloat scaleFactor)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
