Title: [136330] trunk/Source/WebKit/blackberry
- Revision
- 136330
- Author
- [email protected]
- Date
- 2012-12-02 03:30:50 -0800 (Sun, 02 Dec 2012)
Log Message
[BlackBerry]Tap highlight
https://bugs.webkit.org/show_bug.cgi?id=103787
Patch by Tiancheng Jiang <[email protected]> on 2012-12-02
Reviewed by Rob Buis.
RIM PR 248626
Internally Reviewed by Genevieve Mak.
Draw tap highlight as soon as tap on element.
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::touchEvent):
* WebKitSupport/TouchEventHandler.cpp:
(BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
* WebKitSupport/TouchEventHandler.h:
(TouchEventHandler):
Modified Paths
Diff
Modified: trunk/Source/WebKit/blackberry/Api/WebPage.cpp (136329 => 136330)
--- trunk/Source/WebKit/blackberry/Api/WebPage.cpp 2012-12-02 11:23:04 UTC (rev 136329)
+++ trunk/Source/WebKit/blackberry/Api/WebPage.cpp 2012-12-02 11:30:50 UTC (rev 136330)
@@ -4010,9 +4010,16 @@
else if (tEvent.m_type == Platform::TouchEvent::TouchStart || tEvent.m_type == Platform::TouchEvent::TouchCancel)
d->m_pluginMayOpenNewTab = false;
- if (tEvent.m_type == Platform::TouchEvent::TouchStart)
+ if (tEvent.m_type == Platform::TouchEvent::TouchStart) {
d->clearCachedHitTestResult();
+ d->m_touchEventHandler->doFatFingers(tEvent.m_points[0]);
+ // Draw tap highlight as soon as possible if we can
+ Element* elementUnderFatFinger = d->m_touchEventHandler->lastFatFingersResult().nodeAsElementIfApplicable();
+ if (elementUnderFatFinger)
+ d->m_touchEventHandler->drawTapHighlight();
+ }
+
bool handled = false;
if (!event.m_type != Platform::TouchEvent::TouchInjected)
Modified: trunk/Source/WebKit/blackberry/ChangeLog (136329 => 136330)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-12-02 11:23:04 UTC (rev 136329)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-12-02 11:30:50 UTC (rev 136330)
@@ -1,3 +1,22 @@
+2012-12-02 Tiancheng Jiang <[email protected]>
+
+ [BlackBerry]Tap highlight
+ https://bugs.webkit.org/show_bug.cgi?id=103787
+
+ Reviewed by Rob Buis.
+
+ RIM PR 248626
+ Internally Reviewed by Genevieve Mak.
+
+ Draw tap highlight as soon as tap on element.
+
+ * Api/WebPage.cpp:
+ (BlackBerry::WebKit::WebPage::touchEvent):
+ * WebKitSupport/TouchEventHandler.cpp:
+ (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
+ * WebKitSupport/TouchEventHandler.h:
+ (TouchEventHandler):
+
2012-11-28 Cosmin Truta <[email protected]>
[BlackBerry] Set the minimal DOM timer interval to 4 milliseconds
Modified: trunk/Source/WebKit/blackberry/WebKitSupport/TouchEventHandler.cpp (136329 => 136330)
--- trunk/Source/WebKit/blackberry/WebKitSupport/TouchEventHandler.cpp 2012-12-02 11:23:04 UTC (rev 136329)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/TouchEventHandler.cpp 2012-12-02 11:30:50 UTC (rev 136330)
@@ -92,10 +92,7 @@
{
doFatFingers(point);
- // FIXME Draw tap highlight as soon as possible if we can
Element* elementUnderFatFinger = m_lastFatFingersResult.nodeAsElementIfApplicable();
- if (elementUnderFatFinger)
- drawTapHighlight();
// Check for text selection
if (m_lastFatFingersResult.isTextInput()) {
Modified: trunk/Source/WebKit/blackberry/WebKitSupport/TouchEventHandler.h (136329 => 136330)
--- trunk/Source/WebKit/blackberry/WebKitSupport/TouchEventHandler.h 2012-12-02 11:23:04 UTC (rev 136329)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/TouchEventHandler.h 2012-12-02 11:30:50 UTC (rev 136330)
@@ -44,9 +44,10 @@
void playSoundIfAnchorIsTarget() const;
+ void drawTapHighlight();
+
private:
void handleFatFingerPressed();
- void drawTapHighlight();
private:
WebPagePrivate* m_webPage;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
