Title: [136344] trunk/Tools
- Revision
- 136344
- Author
- [email protected]
- Date
- 2012-12-02 05:12:40 -0800 (Sun, 02 Dec 2012)
Log Message
nrwt: remove unused methods in manager.py
https://bugs.webkit.org/show_bug.cgi?id=103828
Reviewed by Eric Seidel.
These two methods weren't being called by anything and were no
longer needed.
* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._get_failures):
(Manager._upload_json_files):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (136343 => 136344)
--- trunk/Tools/ChangeLog 2012-12-02 13:09:17 UTC (rev 136343)
+++ trunk/Tools/ChangeLog 2012-12-02 13:12:40 UTC (rev 136344)
@@ -1,3 +1,17 @@
+2012-12-02 Dirk Pranke <[email protected]>
+
+ nrwt: remove unused methods in manager.py
+ https://bugs.webkit.org/show_bug.cgi?id=103828
+
+ Reviewed by Eric Seidel.
+
+ These two methods weren't being called by anything and were no
+ longer needed.
+
+ * Scripts/webkitpy/layout_tests/controllers/manager.py:
+ (Manager._get_failures):
+ (Manager._upload_json_files):
+
2012-12-02 Laszlo Gombos <[email protected]>
Correct the spelling of the cmakeargs argument
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py (136343 => 136344)
--- trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py 2012-12-02 13:09:17 UTC (rev 136343)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py 2012-12-02 13:12:40 UTC (rev 136344)
@@ -528,14 +528,6 @@
return failed_results
- def _char_for_result(self, result):
- result = result.lower()
- if result in TestExpectations.EXPECTATIONS:
- result_enum_value = TestExpectations.EXPECTATIONS[result]
- else:
- result_enum_value = TestExpectations.MODIFIERS[result]
- return json_layout_results_generator.JSONLayoutResultsGenerator.FAILURE_TO_CHAR[result_enum_value]
-
def _upload_json_files(self, summarized_results, result_summary, individual_test_timings):
"""Writes the results of the test run as JSON files into the results
dir and upload the files to the appengine server.
@@ -579,14 +571,6 @@
self._filesystem.remove(times_json_path)
self._filesystem.remove(incremental_results_path)
- def _num_digits(self, num):
- """Returns the number of digits needed to represent the length of a
- sequence."""
- ndigits = 1
- if len(num):
- ndigits = int(math.log10(len(num))) + 1
- return ndigits
-
def _copy_results_html_file(self):
base_dir = self._port.path_from_webkit_base('LayoutTests', 'fast', 'harness')
results_file = self._filesystem.join(base_dir, 'results.html')
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
