Title: [136408] trunk/Source/WebCore
Revision
136408
Author
[email protected]
Date
2012-12-03 09:54:23 -0800 (Mon, 03 Dec 2012)

Log Message

Web Inspector: free Page resources on inspector disconnect
https://bugs.webkit.org/show_bug.cgi?id=103888

Reviewed by Yury Semikhatsky.

We don't need to keep the page around and can free up memory when disconnecting web inspector.

Not testable.

* inspector/InspectorController.cpp:
(WebCore::InspectorController::disconnectFrontend):
* inspector/InspectorOverlay.cpp:
(WebCore::InspectorOverlay::freePage):
(WebCore):
* inspector/InspectorOverlay.h:
(InspectorOverlay):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (136407 => 136408)


--- trunk/Source/WebCore/ChangeLog	2012-12-03 17:48:42 UTC (rev 136407)
+++ trunk/Source/WebCore/ChangeLog	2012-12-03 17:54:23 UTC (rev 136408)
@@ -1,3 +1,22 @@
+2012-12-03  Konrad Piascik  <[email protected]>
+
+        Web Inspector: free Page resources on inspector disconnect
+        https://bugs.webkit.org/show_bug.cgi?id=103888
+
+        Reviewed by Yury Semikhatsky.
+
+        We don't need to keep the page around and can free up memory when disconnecting web inspector.
+
+        Not testable.
+
+        * inspector/InspectorController.cpp:
+        (WebCore::InspectorController::disconnectFrontend):
+        * inspector/InspectorOverlay.cpp:
+        (WebCore::InspectorOverlay::freePage):
+        (WebCore):
+        * inspector/InspectorOverlay.h:
+        (InspectorOverlay):
+
 2012-12-03  Alexis Menard  <[email protected]>
 
         [GTK] Enable CSS3 background-background position offset by default.

Modified: trunk/Source/WebCore/inspector/InspectorController.cpp (136407 => 136408)


--- trunk/Source/WebCore/inspector/InspectorController.cpp	2012-12-03 17:48:42 UTC (rev 136407)
+++ trunk/Source/WebCore/inspector/InspectorController.cpp	2012-12-03 17:54:23 UTC (rev 136408)
@@ -244,6 +244,8 @@
 
     m_inspectorFrontend.clear();
 
+    // relese overlay page resources
+    m_overlay->freePage();
     InspectorInstrumentation::frontendDeleted();
 }
 

Modified: trunk/Source/WebCore/inspector/InspectorOverlay.cpp (136407 => 136408)


--- trunk/Source/WebCore/inspector/InspectorOverlay.cpp	2012-12-03 17:48:42 UTC (rev 136407)
+++ trunk/Source/WebCore/inspector/InspectorOverlay.cpp	2012-12-03 17:54:23 UTC (rev 136408)
@@ -515,6 +515,11 @@
     info.addMember(m_size);
 }
 
+void InspectorOverlay::freePage()
+{
+    m_overlayPage.clear();
+}
+
 } // namespace WebCore
 
 #endif // ENABLE(INSPECTOR)

Modified: trunk/Source/WebCore/inspector/InspectorOverlay.h (136407 => 136408)


--- trunk/Source/WebCore/inspector/InspectorOverlay.h	2012-12-03 17:48:42 UTC (rev 136407)
+++ trunk/Source/WebCore/inspector/InspectorOverlay.h	2012-12-03 17:54:23 UTC (rev 136408)
@@ -121,6 +121,7 @@
 
     void reportMemoryUsage(MemoryObjectInfo*) const;
 
+    void freePage();
 private:
     InspectorOverlay(Page*, InspectorClient*);
 
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to