Title: [136477] trunk/Source/WebKit2
Revision
136477
Author
[email protected]
Date
2012-12-03 23:36:31 -0800 (Mon, 03 Dec 2012)

Log Message

Coordinated Graphics: Reorder messages to LayerTreeCoordinatorProxy
https://bugs.webkit.org/show_bug.cgi?id=103843

Patch by Huang Dongsung <[email protected]> on 2012-12-03
Reviewed by Noam Rosenthal.

Remove updateViewport() in LayerTreeCoordinatorProxy::setRootCompositingLayer()
because LayerTreeCoordinatorProxy::didRenderFrame() is always called after
setting the root layer. There is no behaviour changes because setting the root
layer isn't actually applied to TextureMapperLayer until DidRenderFrame message
is received.

This is in preparation for refactoring TextureMapper to work in an actor
model (http://webkit.org/b/103854).

* UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.cpp:
(WebKit::LayerTreeCoordinatorProxy::setRootCompositingLayer):
* WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:
(WebKit::LayerTreeCoordinator::flushPendingLayerChanges):

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (136476 => 136477)


--- trunk/Source/WebKit2/ChangeLog	2012-12-04 07:35:33 UTC (rev 136476)
+++ trunk/Source/WebKit2/ChangeLog	2012-12-04 07:36:31 UTC (rev 136477)
@@ -1,3 +1,24 @@
+2012-12-03  Huang Dongsung  <[email protected]>
+
+        Coordinated Graphics: Reorder messages to LayerTreeCoordinatorProxy
+        https://bugs.webkit.org/show_bug.cgi?id=103843
+
+        Reviewed by Noam Rosenthal.
+
+        Remove updateViewport() in LayerTreeCoordinatorProxy::setRootCompositingLayer()
+        because LayerTreeCoordinatorProxy::didRenderFrame() is always called after
+        setting the root layer. There is no behaviour changes because setting the root
+        layer isn't actually applied to TextureMapperLayer until DidRenderFrame message
+        is received.
+
+        This is in preparation for refactoring TextureMapper to work in an actor
+        model (http://webkit.org/b/103854).
+
+        * UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.cpp:
+        (WebKit::LayerTreeCoordinatorProxy::setRootCompositingLayer):
+        * WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:
+        (WebKit::LayerTreeCoordinator::flushPendingLayerChanges):
+
 2012-12-03  Anders Carlsson  <[email protected]>
 
         Make it easier to add more web process initialization parameters

Modified: trunk/Source/WebKit2/UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.cpp (136476 => 136477)


--- trunk/Source/WebKit2/UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.cpp	2012-12-04 07:35:33 UTC (rev 136476)
+++ trunk/Source/WebKit2/UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.cpp	2012-12-04 07:36:31 UTC (rev 136477)
@@ -99,7 +99,6 @@
 void LayerTreeCoordinatorProxy::setRootCompositingLayer(WebLayerID id)
 {
     dispatchUpdate(bind(&LayerTreeRenderer::setRootLayerID, m_renderer.get(), id));
-    updateViewport();
 }
 
 void LayerTreeCoordinatorProxy::setCompositingLayerState(WebLayerID id, const WebLayerInfo& info)

Modified: trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp (136476 => 136477)


--- trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp	2012-12-04 07:35:33 UTC (rev 136476)
+++ trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp	2012-12-04 07:36:31 UTC (rev 136477)
@@ -280,6 +280,7 @@
     if (m_shouldSyncRootLayer) {
         m_webPage->send(Messages::LayerTreeCoordinatorProxy::SetRootCompositingLayer(toCoordinatedGraphicsLayer(m_rootLayer.get())->id()));
         m_shouldSyncRootLayer = false;
+        m_shouldSyncFrame = true;
     }
 
     for (size_t i = 0; i < m_detachedLayers.size(); ++i)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to