Title: [136508] trunk
Revision
136508
Author
[email protected]
Date
2012-12-04 07:19:32 -0800 (Tue, 04 Dec 2012)

Log Message

[chromium] Turn on the new Skia mask blur algorithm.
https://bugs.webkit.org/show_bug.cgi?id=103906

Unreviewed roll out.

The previous patch was premature and is causing issues rolling skia deps and Chromium deps.

Source/WebKit/chromium: 

* skia_webkit.gyp:

LayoutTests: 

* platform/chromium/TestExpectations:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (136507 => 136508)


--- trunk/LayoutTests/ChangeLog	2012-12-04 14:56:21 UTC (rev 136507)
+++ trunk/LayoutTests/ChangeLog	2012-12-04 15:19:32 UTC (rev 136508)
@@ -1,3 +1,14 @@
+2012-12-04  Stephen Chenney  <[email protected]>
+
+        [chromium] Turn on the new Skia mask blur algorithm.
+        https://bugs.webkit.org/show_bug.cgi?id=103906
+
+        Unreviewed roll out.
+
+        The previous patch was premature and is causing issues rolling skia deps and Chromium deps.
+
+        * platform/chromium/TestExpectations:
+
 2012-12-04  Antoine Quint  <[email protected]>
 
         TextTrack's .kind property should return lower-case values

Modified: trunk/LayoutTests/platform/chromium/TestExpectations (136507 => 136508)


--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-12-04 14:56:21 UTC (rev 136507)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-12-04 15:19:32 UTC (rev 136508)
@@ -86,7 +86,6 @@
 webkit.org/b/100272 [ Debug ] fast/media/w3c/test_media_queries.html [ Pass Slow ]
 webkit.org/b/70878 [ Linux Debug ] http/tests/xmlhttprequest/xmlhttprequest-test-send-flag.html [ Pass Slow ]
 webkit.org/b/102179 [ Win Debug ] platform/chromium/virtual/gpu/fast/hidpi/image-set-without-specified-width.html [ Pass Slow ]
-# senorblanco:  Uncomment this after rebaselining for webkit.org/b/103906.
 webkit.org/b/102463 [ Win Debug ] fast/forms/validation-message-appearance.html [ Pass ImageOnlyFailure ]
 webkit.org/b/102464 [ Debug ] fast/images/webgl-teximage2d.html [ Pass Timeout ]
 webkit.org/b/102464 [ Debug ] platform/chromium/virtual/deferred/fast/images/webgl-teximage2d.html [ Pass Timeout ]
@@ -1615,8 +1614,7 @@
 webkit.org/b/98647 [ Android ] compositing/culling/filter-occlusion-blur.html [ ImageOnlyFailure ]
 webkit.org/b/98647 [ Android ] compositing/direct-image-compositing.html [ ImageOnlyFailure ]
 webkit.org/b/98647 [ Android ] compositing/generated-content.html [ ImageOnlyFailure ]
-# senorblanco:  Uncomment this after rebaselining for webkit.org/b/103906.
-# webkit.org/b/98647 [ Android ] compositing/geometry/clipping-foreground.html [ ImageOnlyFailure ]
+webkit.org/b/98647 [ Android ] compositing/geometry/clipping-foreground.html [ ImageOnlyFailure ]
 webkit.org/b/98647 [ Android ] compositing/geometry/composited-html-size.html [ ImageOnlyFailure ]
 webkit.org/b/98647 [ Android ] compositing/geometry/fixed-in-composited.html [ ImageOnlyFailure ]
 webkit.org/b/98647 [ Android ] compositing/geometry/fixed-position.html [ ImageOnlyFailure ]
@@ -1686,12 +1684,10 @@
 webkit.org/b/98762 [ Android ] fast/layers/no-clipping-overflow-hidden-added-after-transition.html [ ImageOnlyFailure ]
 webkit.org/b/98762 [ Android ] compositing/absolute-position-changed-with-composited-parent-layer.html [ ImageOnlyFailure ]
 webkit.org/b/98762 [ Android ] compositing/animation/state-at-end-event-transform-layer.html [ ImageOnlyFailure ]
-# senorblanco:  Uncomment this after rebaselining for webkit.org/b/103906.
 webkit.org/b/98762 [ Android ] compositing/culling/scrolled-within-boxshadow.html [ ImageOnlyFailure ]
 webkit.org/b/98762 [ Android ] compositing/geometry/abs-position-inside-opacity.html [ ImageOnlyFailure ]
 webkit.org/b/98762 [ Android ] compositing/geometry/partial-layout-update.html [ ImageOnlyFailure ]
 webkit.org/b/98762 [ Android ] compositing/geometry/root-layer-update.html [ ImageOnlyFailure ]
-# senorblanco:  Uncomment this after rebaselining for webkit.org/b/103906.
 webkit.org/b/98762 [ Android ] compositing/iframes/composited-iframe-alignment.html [ ImageOnlyFailure ]
 webkit.org/b/98762 [ Android ] compositing/overflow/ancestor-overflow.html [ ImageOnlyFailure ]
 webkit.org/b/98762 [ Android ] compositing/overflow/overflow-positioning.html [ ImageOnlyFailure ]
@@ -1709,8 +1705,7 @@
 webkit.org/b/98763 [ Android ] compositing/geometry/vertical-scroll-composited.html [ ImageOnlyFailure ]
 webkit.org/b/98763 [ Android ] compositing/layer-creation/fixed-position-and-transform.html [ ImageOnlyFailure ]
 webkit.org/b/98763 [ Android ] compositing/layer-creation/fixed-position-under-transform.html [ ImageOnlyFailure ]
-# senorblanco:  Uncomment this after rebaselining for webkit.org/b/103906.
-# webkit.org/b/98763 [ Android ] compositing/masks/masked-ancestor.html [ ImageOnlyFailure ]
+webkit.org/b/98763 [ Android ] compositing/masks/masked-ancestor.html [ ImageOnlyFailure ]
 webkit.org/b/98763 [ Android ] compositing/masks/multiple-masks.html [ ImageOnlyFailure ]
 # tasak: Uncomment this after rebaselining for webkit.org/b/103700.
 # webkit.org/b/98763 [ Android ] compositing/masks/simple-composited-mask.html [ ImageOnlyFailure ]
@@ -2036,7 +2031,6 @@
 crbug.com/28005 [ Android ] fast/css/color-correction-on-backgrounds.html [ Failure ]
 crbug.com/28005 [ Android ] fast/css/color-correction-on-text.html [ Failure ]
 crbug.com/28005 [ Android ] fast/css/color-correction.html [ Failure ]
-# senorblanco:  Uncomment these after rebaselining for webkit.org/b/103906.
 crbug.com/28005 [ Android ] fast/css/color-correction-on-box-shadow.html [ Failure ]
 crbug.com/28005 [ Android ] fast/css/color-correction-on-text-shadow.html [ Failure ]
 crbug.com/28005 [ Android Win ] fast/css/color-correction-on-background-image.html [ Failure ]
@@ -3929,12 +3923,6 @@
 
 webkit.org/b/63899 [ Mac Win Android ] fast/replaced/border-radius-clip-content-edge.html [ Pass ImageOnlyFailure ]
 
-# These will require rebaselining after switching to the separable mask blur implementation in Skia.
-Bug(senorblanco) compositing/masks/masked-ancestor.html [ ImageOnlyFailure ]
-Bug(senorblanco) svg/css/text-gradient-shadow.svg [ ImageOnlyFailure ]
-Bug(senorblanco) svg/custom/repaint-shadow.svg [ ImageOnlyFailure ]
-Bug(senorblanco) transitions/svg-text-shadow-transition.html [ ImageOnlyFailure ]
-
 # Started failing on r128793
 webkit.org/b/96953 [ Win Linux ] http/tests/inspector/network/network-xhr-replay.html [ Timeout Crash ]
 

Modified: trunk/Source/WebKit/chromium/ChangeLog (136507 => 136508)


--- trunk/Source/WebKit/chromium/ChangeLog	2012-12-04 14:56:21 UTC (rev 136507)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-12-04 15:19:32 UTC (rev 136508)
@@ -1,3 +1,14 @@
+2012-12-04  Stephen Chenney  <[email protected]>
+
+        [chromium] Turn on the new Skia mask blur algorithm.
+        https://bugs.webkit.org/show_bug.cgi?id=103906
+
+        Unreviewed roll out.
+
+        The previous patch was premature and is causing issues rolling skia deps and Chromium deps.
+
+        * skia_webkit.gyp:
+
 2012-12-03  Joshua Bell  <[email protected]>
 
         IndexedDB: Correct database version after aborted upgrade

Modified: trunk/Source/WebKit/chromium/skia_webkit.gyp (136507 => 136508)


--- trunk/Source/WebKit/chromium/skia_webkit.gyp	2012-12-04 14:56:21 UTC (rev 136507)
+++ trunk/Source/WebKit/chromium/skia_webkit.gyp	2012-12-04 15:19:32 UTC (rev 136508)
@@ -40,9 +40,14 @@
           # Place defines here that require significant WebKit rebaselining, or that
           # are otherwise best removed in WebKit and then rolled into Chromium.
           # Defines should be in single quotes and a comma must appear after every one.
+          # DO NOT remove the define until you are ready to rebaseline, and
+          # AFTER the flag has been removed from skia.gyp in Chromium.
+
           'SK_DISABLE_DITHER_32BIT_GRADIENT',
 
           'SK_DISABLE_DASHING_OPTIMIZATION',
+
+          'SK_DISABLE_SEPARABLE_MASK_BLUR',
         ],
       },
     },
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to