Title: [136512] trunk/Source/WebKit/blackberry
- Revision
- 136512
- Author
- [email protected]
- Date
- 2012-12-04 08:53:42 -0800 (Tue, 04 Dec 2012)
Log Message
[BlackBerry] Remove assert and fix conditional for out of bounds requests in InputHandler::spannableTextInRange
https://bugs.webkit.org/show_bug.cgi?id=104001
Reviewed by Rob Buis.
PR 257723.
Remove assert and update early return to allow out of bounds
request at end of field.
Reviewed Internally by Gen Mak.
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::spannableTextInRange):
Modified Paths
Diff
Modified: trunk/Source/WebKit/blackberry/ChangeLog (136511 => 136512)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-12-04 16:52:01 UTC (rev 136511)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-12-04 16:53:42 UTC (rev 136512)
@@ -1,3 +1,20 @@
+2012-12-04 Mike Fenton <[email protected]>
+
+ [BlackBerry] Remove assert and fix conditional for out of bounds requests in InputHandler::spannableTextInRange
+ https://bugs.webkit.org/show_bug.cgi?id=104001
+
+ Reviewed by Rob Buis.
+
+ PR 257723.
+
+ Remove assert and update early return to allow out of bounds
+ request at end of field.
+
+ Reviewed Internally by Gen Mak.
+
+ * WebKitSupport/InputHandler.cpp:
+ (BlackBerry::WebKit::InputHandler::spannableTextInRange):
+
2012-12-04 Jakob Petsovits <[email protected]>
[BlackBerry] Store rendered regions in pixel contents coordinates.
Modified: trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp (136511 => 136512)
--- trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp 2012-12-04 16:52:01 UTC (rev 136511)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp 2012-12-04 16:53:42 UTC (rev 136512)
@@ -1925,10 +1925,9 @@
if (!isActiveTextEdit())
return 0;
- if (start == end)
+ if (start >= end)
return 0;
- ASSERT(end > start);
int length = end - start;
WTF::String textString = elementText().substring(start, length);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
