Title: [136540] trunk/Source/WebCore
- Revision
- 136540
- Author
- ale...@webkit.org
- Date
- 2012-12-04 11:29:48 -0800 (Tue, 04 Dec 2012)
Log Message
Web Inspector: Can't take a heap snapshot in chromium ("Uncaught ReferenceError")
https://bugs.webkit.org/show_bug.cgi?id=103997
Patch by Yury Semikhatsky <yu...@chromium.org> on 2012-12-04
Reviewed by Pavel Feldman.
utilities.js used in both page and worker contexts should not access window
object as there is no one in case of workers. NonLeakingMutationObserver implementation
has moved to DOMExtension.js
* inspector/front-end/DOMExtension.js:
(NonLeakingMutationObserver.NonLeakingMutationObserver._unloadListener):
(NonLeakingMutationObserver):
(NonLeakingMutationObserver.prototype.observe):
(NonLeakingMutationObserver.prototype.disconnect):
* inspector/front-end/utilities.js:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (136539 => 136540)
--- trunk/Source/WebCore/ChangeLog 2012-12-04 19:29:13 UTC (rev 136539)
+++ trunk/Source/WebCore/ChangeLog 2012-12-04 19:29:48 UTC (rev 136540)
@@ -115,6 +115,20 @@
Reviewed by Ryosuke Niwa.
+ Remove unwanted null check from r136525
+
+ No new tests : just a refactor, existing tests should cover.
+
+ * css/CSSParser.cpp:
+ (WebCore::isForwardSlashOperator):
+
+2012-12-04 Alexis Menard <ale...@webkit.org>
+
+ Add an helper function in CSSParser to check for '/' character.
+ https://bugs.webkit.org/show_bug.cgi?id=104009
+
+ Reviewed by Ryosuke Niwa.
+
I'm about to add the same pattern in a following patch. Let's do an
helper function first. We also did that for the comma. The slash
character is pretty used in shorthands definitions.
Modified: trunk/Source/WebCore/css/CSSParser.cpp (136539 => 136540)
--- trunk/Source/WebCore/css/CSSParser.cpp 2012-12-04 19:29:13 UTC (rev 136539)
+++ trunk/Source/WebCore/css/CSSParser.cpp 2012-12-04 19:29:48 UTC (rev 136540)
@@ -1654,7 +1654,8 @@
static inline bool isForwardSlashOperator(CSSParserValue* value)
{
- return value && value->unit == CSSParserValue::Operator && value->iValue == '/';
+ ASSERT(value);
+ return value->unit == CSSParserValue::Operator && value->iValue == '/';
}
bool CSSParser::validWidth(CSSParserValue* value)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
