Title: [136561] trunk/Source/WebCore
- Revision
- 136561
- Author
- [email protected]
- Date
- 2012-12-04 14:00:00 -0800 (Tue, 04 Dec 2012)
Log Message
[User Timing] Fix negative durations
https://bugs.webkit.org/show_bug.cgi?id=104038
Reviewed by Tony Gentilcore.
At some point, we went from passing in a duration to passing in the end time. User Timing
wasn't updated.
Tests: http/tests/w3c/webperf/submission/Intel/user-timing
* page/PerformanceMark.h:
(WebCore::PerformanceMark::PerformanceMark):
* page/PerformanceUserTiming.cpp:
(WebCore::UserTiming::measure):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (136560 => 136561)
--- trunk/Source/WebCore/ChangeLog 2012-12-04 21:50:18 UTC (rev 136560)
+++ trunk/Source/WebCore/ChangeLog 2012-12-04 22:00:00 UTC (rev 136561)
@@ -1,3 +1,20 @@
+2012-12-04 James Simonsen <[email protected]>
+
+ [User Timing] Fix negative durations
+ https://bugs.webkit.org/show_bug.cgi?id=104038
+
+ Reviewed by Tony Gentilcore.
+
+ At some point, we went from passing in a duration to passing in the end time. User Timing
+ wasn't updated.
+
+ Tests: http/tests/w3c/webperf/submission/Intel/user-timing
+
+ * page/PerformanceMark.h:
+ (WebCore::PerformanceMark::PerformanceMark):
+ * page/PerformanceUserTiming.cpp:
+ (WebCore::UserTiming::measure):
+
2012-12-04 Abhishek Arya <[email protected]>
Heap-use-after-free in WebCore::StyleCachedImageSet::cssValue
Modified: trunk/Source/WebCore/page/PerformanceMark.h (136560 => 136561)
--- trunk/Source/WebCore/page/PerformanceMark.h 2012-12-04 21:50:18 UTC (rev 136560)
+++ trunk/Source/WebCore/page/PerformanceMark.h 2012-12-04 22:00:00 UTC (rev 136561)
@@ -39,7 +39,7 @@
static PassRefPtr<PerformanceMark> create(const String& name, double startTime) { return adoptRef(new PerformanceMark(name, startTime)); }
private:
- PerformanceMark(const String& name, double startTime) : PerformanceEntry(name, "mark", startTime, 0.0) { }
+ PerformanceMark(const String& name, double startTime) : PerformanceEntry(name, "mark", startTime, startTime) { }
~PerformanceMark() { }
};
Modified: trunk/Source/WebCore/page/PerformanceUserTiming.cpp (136560 => 136561)
--- trunk/Source/WebCore/page/PerformanceUserTiming.cpp 2012-12-04 21:50:18 UTC (rev 136560)
+++ trunk/Source/WebCore/page/PerformanceUserTiming.cpp 2012-12-04 22:00:00 UTC (rev 136561)
@@ -154,7 +154,7 @@
return;
}
- insertPerformanceEntry(m_measuresMap, PerformanceMeasure::create(measureName, startTime, endTime - startTime));
+ insertPerformanceEntry(m_measuresMap, PerformanceMeasure::create(measureName, startTime, endTime));
}
void UserTiming::clearMeasures(const String& measureName)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
