Title: [136571] trunk/LayoutTests
Revision
136571
Author
[email protected]
Date
2012-12-04 14:29:27 -0800 (Tue, 04 Dec 2012)

Log Message

[chromium] Layout test inspector-protocol/debugger-pause-dedicated-worker.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=101229

Reviewed by Vsevolod Vlasov.

Removed unnecessary logging that introduced flakiness to the tests.

* inspector-protocol/debugger-pause-dedicated-worker-expected.txt:
* inspector-protocol/debugger-pause-dedicated-worker.html:
* inspector-protocol/debugger-terminate-dedicated-worker-while-paused-expected.txt:
* inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html:
* platform/chromium/TestExpectations:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (136570 => 136571)


--- trunk/LayoutTests/ChangeLog	2012-12-04 22:19:53 UTC (rev 136570)
+++ trunk/LayoutTests/ChangeLog	2012-12-04 22:29:27 UTC (rev 136571)
@@ -1,3 +1,18 @@
+2012-12-04  Yury Semikhatsky  <[email protected]>
+
+        [chromium] Layout test inspector-protocol/debugger-pause-dedicated-worker.html is flaky
+        https://bugs.webkit.org/show_bug.cgi?id=101229
+
+        Reviewed by Vsevolod Vlasov.
+
+        Removed unnecessary logging that introduced flakiness to the tests.
+
+        * inspector-protocol/debugger-pause-dedicated-worker-expected.txt:
+        * inspector-protocol/debugger-pause-dedicated-worker.html:
+        * inspector-protocol/debugger-terminate-dedicated-worker-while-paused-expected.txt:
+        * inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html:
+        * platform/chromium/TestExpectations:
+
 2012-12-04  Emil A Eklund  <[email protected]>
 
         Unreviewed chromium rebaselines.

Modified: trunk/LayoutTests/inspector-protocol/debugger-pause-dedicated-worker-expected.txt (136570 => 136571)


--- trunk/LayoutTests/inspector-protocol/debugger-pause-dedicated-worker-expected.txt	2012-12-04 22:19:53 UTC (rev 136570)
+++ trunk/LayoutTests/inspector-protocol/debugger-pause-dedicated-worker-expected.txt	2012-12-04 22:29:27 UTC (rev 136571)
@@ -1,5 +1,4 @@
 Started worker
-didEnableWorkerDebugging
 Worker created
 didConnectToWorker
 SUCCESS: Worker paused

Modified: trunk/LayoutTests/inspector-protocol/debugger-pause-dedicated-worker.html (136570 => 136571)


--- trunk/LayoutTests/inspector-protocol/debugger-pause-dedicated-worker.html	2012-12-04 22:19:53 UTC (rev 136570)
+++ trunk/LayoutTests/inspector-protocol/debugger-pause-dedicated-worker.html	2012-12-04 22:29:27 UTC (rev 136571)
@@ -37,9 +37,7 @@
         if ("error" in messageObject) {
             InspectorTest.log("FAIL: Couldn't enable worker debugger: " + messageObject.error.message);
             InspectorTest.completeTest();
-            return;
         }
-        InspectorTest.log("didEnableWorkerDebugging");
     }
     InspectorTest.sendCommand("Worker.enable", {}, didEnableWorkerDebugging);
 

Modified: trunk/LayoutTests/inspector-protocol/debugger-terminate-dedicated-worker-while-paused-expected.txt (136570 => 136571)


--- trunk/LayoutTests/inspector-protocol/debugger-terminate-dedicated-worker-while-paused-expected.txt	2012-12-04 22:19:53 UTC (rev 136570)
+++ trunk/LayoutTests/inspector-protocol/debugger-terminate-dedicated-worker-while-paused-expected.txt	2012-12-04 22:29:27 UTC (rev 136571)
@@ -1,7 +1,6 @@
 Test that inspected page won't crash if inspected worker is terminated while it is paused. Test passes if it doesn't crash. Bug 101065.
 Started worker
 Worker created
-didEnableWorkerDebugging
 didConnectToWorker
 Worker paused
 SUCCESS: Did terminate paused worker

Modified: trunk/LayoutTests/inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html (136570 => 136571)


--- trunk/LayoutTests/inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html	2012-12-04 22:19:53 UTC (rev 136570)
+++ trunk/LayoutTests/inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html	2012-12-04 22:29:27 UTC (rev 136571)
@@ -38,9 +38,7 @@
         if ("error" in messageObject) {
             InspectorTest.log("FAIL: Couldn't enable worker debugger: " + messageObject.error.message);
             InspectorTest.completeTest();
-            return;
         }
-        InspectorTest.log("didEnableWorkerDebugging");
     }
     InspectorTest.sendCommand("Worker.enable", {}, didEnableWorkerDebugging);
 

Modified: trunk/LayoutTests/platform/chromium/TestExpectations (136570 => 136571)


--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-12-04 22:19:53 UTC (rev 136570)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-12-04 22:29:27 UTC (rev 136571)
@@ -4063,7 +4063,7 @@
 webkit.org/b/101253 [ Lion Debug ] ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling.htm [ Pass Failure ]
 
 # Has been flaky since at least r133043
-webkit.org/b/101229 inspector-protocol/debugger-pause-dedicated-worker.html [ Failure Pass Crash ]
+webkit.org/b/101229 inspector-protocol/debugger-pause-dedicated-worker.html [ Pass Crash ]
 
 # Started failing with r133224-133226 (probably 133224)
 webkit.org/b/101255 [ Mac Android ] fast/repaint/block-selection-gap-in-table-cell.html [ ImageOnlyFailure ]
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to