Title: [136577] trunk/Source/WebCore
- Revision
- 136577
- Author
- [email protected]
- Date
- 2012-12-04 14:44:02 -0800 (Tue, 04 Dec 2012)
Log Message
Simplify ShadowRoot::cloneNode(bool,ExceptionCode)
https://bugs.webkit.org/show_bug.cgi?id=103928
Patch by Elliott Sprehn <[email protected]> on 2012-12-04
Reviewed by Dimitri Glazkov.
ShadowRoot can never be cloned and ShadowRoot::cloneNode(bool) always
returns null so there's no reason to have code in the cloneNode method
for script that acts as if it may not return null.
* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::cloneNode):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (136576 => 136577)
--- trunk/Source/WebCore/ChangeLog 2012-12-04 22:43:42 UTC (rev 136576)
+++ trunk/Source/WebCore/ChangeLog 2012-12-04 22:44:02 UTC (rev 136577)
@@ -1,3 +1,17 @@
+2012-12-04 Elliott Sprehn <[email protected]>
+
+ Simplify ShadowRoot::cloneNode(bool,ExceptionCode)
+ https://bugs.webkit.org/show_bug.cgi?id=103928
+
+ Reviewed by Dimitri Glazkov.
+
+ ShadowRoot can never be cloned and ShadowRoot::cloneNode(bool) always
+ returns null so there's no reason to have code in the cloneNode method
+ for script that acts as if it may not return null.
+
+ * dom/ShadowRoot.cpp:
+ (WebCore::ShadowRoot::cloneNode):
+
2012-12-04 Elliott Sprehn <[email protected]>
setIsInTopLayer is not really a setter
Modified: trunk/Source/WebCore/dom/ShadowRoot.cpp (136576 => 136577)
--- trunk/Source/WebCore/dom/ShadowRoot.cpp 2012-12-04 22:43:42 UTC (rev 136576)
+++ trunk/Source/WebCore/dom/ShadowRoot.cpp 2012-12-04 22:44:02 UTC (rev 136577)
@@ -164,15 +164,10 @@
return 0;
}
-PassRefPtr<Node> ShadowRoot::cloneNode(bool deep, ExceptionCode& ec)
+PassRefPtr<Node> ShadowRoot::cloneNode(bool, ExceptionCode& ec)
{
- RefPtr<Node> clone = cloneNode(deep);
- if (!clone) {
- ec = DATA_CLONE_ERR;
- return 0;
- }
-
- return clone;
+ ec = DATA_CLONE_ERR;
+ return 0;
}
String ShadowRoot::innerHTML() const
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
